Skip to content

Carrousel2: replace isFullscreen and isNavigationHide into a new prop navigationPosition #579

Description

@2fd
  • deprecate props isFullscreen and isNavigationHide
  • add new enum NavigationPosition
  • add a new prop navigationPositition: NavigationPosition where:
    • navigationPosition={NavigationPosition.Outer}is the default value and is equal to isFullscreen={false} and isNavigationHide={false}
    • navigationPosition={NavigationPosition.Inner}is equal to isFullscreen={true} and isNavigationHide={false}
    • navigationPosition={NavigationPosition.None}is equal to isNavigationHide={false}
enum NavigationPosition {
    None = 'none',
    Inner = 'inner',
    Outer = 'outer',
}

type Carousel2Props = {
    // ...
    navigationPosition: NavigationPosition
    // ...
}

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions