Skip to content

Conversation

porfanid
Copy link

Sets up the environment for offline unit tests within the nightly workflow.

  • Ensures tests can run without network access by setting necessary environment variables.
  • Creates a dedicated directory for Hugging Face home to avoid conflicts.

@porfanid porfanid requested a review from loadams as a code owner August 24, 2025 16:22
@sfc-gh-truwase
Copy link
Collaborator

sfc-gh-truwase commented Aug 27, 2025

@porfanid thanks for this PR. Can you share the motivation? Specifically, are you addressing some failure or missing functionality in your scenario?

@loadams
Copy link
Collaborator

loadams commented Aug 28, 2025

@porfanid thanks for this PR. Can you share the motivation? Specifically, are you addressing some failure or missing functionality in your scenario?

@porfanid - agreed with Tunji, we haven't run this test in a while, so we would ideally be refactoring it to run again. Are you trying to run with runners in your branch? Since these changes still look to be for the overall GH runner CI

@loadams loadams self-assigned this Aug 28, 2025
@loadams
Copy link
Collaborator

loadams commented Sep 2, 2025

Hi @porfanid - following up on this?

@porfanid
Copy link
Author

Hey @loadams and @sfc-gh-truwase , sorry for showing up late, I was having a lot of projects to work on. Well, I was thinking that because some tests required internet connection to run and the workers don't have internet access, they could not run. I actually don't know if the custom runners have internet access and I took a guess that they don't.

@loadams
Copy link
Collaborator

loadams commented Oct 16, 2025

Hey @loadams and @sfc-gh-truwase , sorry for showing up late, I was having a lot of projects to work on. Well, I was thinking that because some tests required internet connection to run and the workers don't have internet access, they could not run. I actually don't know if the custom runners have internet access and I took a guess that they don't.

@porfanid - the runners are connected to the network, they use the network to clone the git repo, pull packages, etc.

Are you trying to run in your branch or what errors are you trying to resolve?

@porfanid
Copy link
Author

I was trying to make the tests able to run on a github runner cause I don't have a custom runner to run those on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants