Skip to content

Ensure installer provisions SteamCMD dependencies#9

Open
demassimo wants to merge 1 commit into
mainfrom
codex/fix-app-installer-for-ubuntu
Open

Ensure installer provisions SteamCMD dependencies#9
demassimo wants to merge 1 commit into
mainfrom
codex/fix-app-installer-for-ubuntu

Conversation

@demassimo
Copy link
Copy Markdown
Owner

Summary

  • enable the Ubuntu multiverse repository and i386 architecture before installing packages
  • install SteamCMD and its 32-bit runtime libraries alongside the panel dependencies
  • document that the automated installer now provisions SteamCMD on Ubuntu

Testing

  • bash -n scripts/install_panel.sh

https://chatgpt.com/codex/tasks/task_e_68f53bb3ab408331ac11834675ab63a6

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread scripts/install_panel.sh
Comment on lines +153 to +158
cat >"${ENV_FILE}" <<ENV
# Managed by install_panel.sh
FLASK_ENV=production
RUSTPANEL_USER=${PANEL_LOGIN_USER}
RUSTPANEL_PASSWORD_HASH=${PANEL_PASSWORD_HASH}
RUST_SERVICE=${RUST_SERVER_SERVICE}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P0 Badge Quote password hash when writing env file

The installer writes RUSTPANEL_PASSWORD_HASH=${PANEL_PASSWORD_HASH} directly into the generated environment file. The PBKDF2 hash contains $ separators, so when systemd parses the file it performs shell-like expansion and drops everything after the first $. The application then receives an invalid hash and check_password_hash raises ValueError, making login impossible. Wrap the hash in quotes (or escape the $ characters) before writing the line so the literal value is preserved.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@codex fix

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary

  • Wrapped the generated panel password hash in double quotes when writing scripts/install_panel.sh so systemd reads the full PBKDF2 value without truncating on $. scripts/install_panel.shL153-L164

Testing

  • bash -n scripts/install_panel.sh

View task →

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant