Ensure installer provisions SteamCMD dependencies#9
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| cat >"${ENV_FILE}" <<ENV | ||
| # Managed by install_panel.sh | ||
| FLASK_ENV=production | ||
| RUSTPANEL_USER=${PANEL_LOGIN_USER} | ||
| RUSTPANEL_PASSWORD_HASH=${PANEL_PASSWORD_HASH} | ||
| RUST_SERVICE=${RUST_SERVER_SERVICE} |
There was a problem hiding this comment.
Quote password hash when writing env file
The installer writes RUSTPANEL_PASSWORD_HASH=${PANEL_PASSWORD_HASH} directly into the generated environment file. The PBKDF2 hash contains $ separators, so when systemd parses the file it performs shell-like expansion and drops everything after the first $. The application then receives an invalid hash and check_password_hash raises ValueError, making login impossible. Wrap the hash in quotes (or escape the $ characters) before writing the line so the literal value is preserved.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Summary
- Wrapped the generated panel password hash in double quotes when writing
scripts/install_panel.shso systemd reads the full PBKDF2 value without truncating on$. scripts/install_panel.shL153-L164
Testing
- ✅
bash -n scripts/install_panel.sh
Summary
Testing
https://chatgpt.com/codex/tasks/task_e_68f53bb3ab408331ac11834675ab63a6