Skip to content

Remove dedicated superuser UI route and rename global admin#326

Open
demassimo wants to merge 1 commit into
mainfrom
codex/remove-/superuser/ui-from-nginx-x-and-app
Open

Remove dedicated superuser UI route and rename global admin#326
demassimo wants to merge 1 commit into
mainfrom
codex/remove-/superuser/ui-from-nginx-x-and-app

Conversation

@demassimo
Copy link
Copy Markdown
Owner

Summary

  • remove the dedicated /superuser nginx locations and rely on the main SPA entry point
  • simplify the frontend to drop the special superuser UI mode while keeping admin navigation in-app
  • relabel superuser affordances to Global admin and remove the unused standalone superuser UI bundle

Testing

  • Not run (not requested)

Codex Task

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines 36 to 38
location / {
try_files $uri /index.html;
}
Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve assets when hitting legacy /superuser/ path

Removing the dedicated /superuser locations means /superuser/… now falls through to the catch‑all location / (lines 36‑38), which serves index.html from that subpath. The SPA still references its JS/CSS with relative URLs like assets/app.js, so when the document is loaded at /superuser/ the browser requests /superuser/assets/..., which Nginx does not serve and instead returns HTML. Any operator following an existing /superuser/ bookmark now gets a broken page with no scripts or styles. Redirecting /superuser/* to / or making the asset URLs absolute is needed to keep the legacy entry point usable.

Useful? React with 👍 / 👎.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant