Skip to content

Conversation

xsoar-bot
Copy link
Contributor

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Contributor

@Radargoger

Description

Auto-Generated Documentation Requiring Modification

Video Link

Short demo video of the Pack usage. Speeds up the review. Optional but recommended. Use a video sharing service such as Google Drive or YouTube.

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Community Support Level Indicates that the contribution is for Community supported pack labels Jun 9, 2025
@content-bot content-bot changed the base branch from master to contrib/xsoar-contrib_Radargoger-contrib-SOCRadarTakedown June 9, 2025 19:21
@content-bot content-bot requested a review from itssapir June 9, 2025 19:21
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Rest assured - our content wizard @itssapir will very shortly look over your proposed changes.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution, please ask the reviewer to update your information in the pack contributors file. See more information here link

@content-bot content-bot added the Contribution Form Filled Whether contribution form filled or not. label Jun 9, 2025
@itssapir
Copy link
Contributor

Hi @Radargoger,
Thank you for your contribution!

Your PR review will be slightly delayed, I apologize in advance.
In the meantime, there are various errors in the pre-commit check that need to be fixed.

I'm available for any of your questions here or on slack.
Thanks again.

Copy link
Contributor

@itssapir itssapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Radargoger,
Thank you for your contribution.

Please see my initial review below.
Note that a few of the comments were only added once but they are relevant for other commands as well.
There are also various errors in the pre-commit check, please have a look and address those.

Please feel free to reach out to me with any questions - I'm available here or on slack :)
Thanks again

update pack_metadajson
@CLAassistant
Copy link

CLAassistant commented Jun 25, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@itssapir itssapir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @Radargoger,
I went through most of the changes and marked most comments as resolved.
See the comments that are left.

There are still a lot of errors in the pre-commit step that need to be resolved.
If you have any questions about those, feel free to reach out to me here or on slack,
Thanks.

@Radargoger
Copy link
Contributor

Radargoger commented Jul 1, 2025 via email

@Radargoger
Copy link
Contributor

Please update the status or add a new comment to go further

@itssapir
Copy link
Contributor

itssapir commented Jul 3, 2025

Please update the status or add a new comment to go further

Hi @Radargoger, I emailed you a couple of days ago regarding the request for further assistance.
Are you a part of our DFIR community on slack? It would be much simpler if we could talk through slack.

Best regards,
Sapir

@Radargoger
Copy link
Contributor

Radargoger commented Jul 4, 2025 via email

@Radargoger
Copy link
Contributor

This PR was opened in the wrong repository.
The correct PR is now at: xsoar-contrib#372
Closing this one.

@Radargoger
Copy link
Contributor

This PR was opened in the wrong repository.
The correct PR is now at: xsoar-contrib#372
Closing this one. @itssapir

@itssapir itssapir added docs-approved ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. labels Jul 21, 2025
@content-bot
Copy link
Collaborator

For the Reviewer: Trigger build request has been accepted for this contribution PR.

@content-bot
Copy link
Collaborator

For the Reviewer: Successfully created a pipeline in GitLab with url: https://gitlab.xdr.pan.local/xdr/cortex-content/content/-/pipelines/4238826

@content-bot content-bot removed the ready-for-instance-test In contribution PRs, this label will cause a trigger of a build with a modified pack from the PR. label Jul 21, 2025
@itssapir itssapir merged commit fd5b659 into demisto:contrib/xsoar-contrib_Radargoger-contrib-SOCRadarTakedown Jul 21, 2025
14 checks passed
Copy link

Thank you for your contribution. Your external PR has been merged and the changes are now included in an internal PR for further review. The internal PR will be merged to the master branch within 3 business days.

itssapir added a commit that referenced this pull request Jul 21, 2025
* "pack contribution initial commit"

* Update pack_metadata.json

update pack_metadajson

* Update SOCRadarTakedown.yml

* Update SOCRadarTakedown.py

* Update Packs/SOCRadarTakedown/Integrations/SOCRadarTakedown/SOCRadarTakedown.yml



* Create SOCRadarTakedown_description.md

* Update Packs/SOCRadarTakedown/pack_metadata.json



* Delete Packs/SOCRadarTakedown/Integrations/SOCRadarTakedown/SOCRadarTakedown_description.md

* pre-commit fixes

* fix image

* change to credentials object and add description file

* fix change to credentials, and markdownlint pass

* Update SOCRadarTakedown.py

* Update README.md

* Update SOCRadarTakedown_description.md

* Update SOCRadarTakedown.yml

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.yml

* Update README.md

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.py

* ruff fixes

* Update README.md

* Update README.md

* Update README.md

* remove README.md empty lines

* Delete Packs/SOCRadarTakedown/README.md

* Add empty readme

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Radargoger <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
TOUFIKIzakarya pushed a commit to TOUFIKIzakarya/content that referenced this pull request Jul 24, 2025
…40654)

* "pack contribution initial commit"

* Update pack_metadata.json

update pack_metadajson

* Update SOCRadarTakedown.yml

* Update SOCRadarTakedown.py

* Update Packs/SOCRadarTakedown/Integrations/SOCRadarTakedown/SOCRadarTakedown.yml



* Create SOCRadarTakedown_description.md

* Update Packs/SOCRadarTakedown/pack_metadata.json



* Delete Packs/SOCRadarTakedown/Integrations/SOCRadarTakedown/SOCRadarTakedown_description.md

* pre-commit fixes

* fix image

* change to credentials object and add description file

* fix change to credentials, and markdownlint pass

* Update SOCRadarTakedown.py

* Update README.md

* Update SOCRadarTakedown_description.md

* Update SOCRadarTakedown.yml

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.yml

* Update README.md

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.py

* ruff fixes

* Update README.md

* Update README.md

* Update README.md

* remove README.md empty lines

* Delete Packs/SOCRadarTakedown/README.md

* Add empty readme

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Radargoger <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
xsoar-bot added a commit to xsoar-contrib/content that referenced this pull request Sep 17, 2025
…40654)

* "pack contribution initial commit"

* Update pack_metadata.json

update pack_metadajson

* Update SOCRadarTakedown.yml

* Update SOCRadarTakedown.py

* Update Packs/SOCRadarTakedown/Integrations/SOCRadarTakedown/SOCRadarTakedown.yml



* Create SOCRadarTakedown_description.md

* Update Packs/SOCRadarTakedown/pack_metadata.json



* Delete Packs/SOCRadarTakedown/Integrations/SOCRadarTakedown/SOCRadarTakedown_description.md

* pre-commit fixes

* fix image

* change to credentials object and add description file

* fix change to credentials, and markdownlint pass

* Update SOCRadarTakedown.py

* Update README.md

* Update SOCRadarTakedown_description.md

* Update SOCRadarTakedown.yml

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.yml

* Update README.md

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.py

* Update SOCRadarTakedown.py

* ruff fixes

* Update README.md

* Update README.md

* Update README.md

* remove README.md empty lines

* Delete Packs/SOCRadarTakedown/README.md

* Add empty readme

---------

Co-authored-by: xsoar-bot <[email protected]>
Co-authored-by: Radargoger <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Community Support Level Indicates that the contribution is for Community supported pack Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved External PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants