Skip to content

Conversation

S3B4SZ17
Copy link
Contributor

@S3B4SZ17 S3B4SZ17 commented Jul 22, 2025

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Description

Updating the Sysdig default Classifier, Incident fields and Layout
Updated the overall docs and release notes to reflect current state and changes

Must have

  • Tests
  • Documentation

@content-bot content-bot added Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack labels Jul 22, 2025
@content-bot content-bot changed the base branch from master to contrib/sysdiglabs_feat/sydig-runtime-classifier July 22, 2025 16:40
@content-bot content-bot requested a review from YaelShamai July 22, 2025 16:40
@content-bot
Copy link
Collaborator

Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YaelShamai will know the proposed changes are ready to be reviewed.
For your convenience, here is a link to the contributions SLAs document.

@content-bot
Copy link
Collaborator

Hi @S3B4SZ17, thanks for contributing to the XSOAR marketplace. To receive credit for your generous contribution please follow this link.

@content-bot content-bot added Partner-Approved Contribution Form Filled Whether contribution form filled or not. Partner labels Jul 22, 2025
@S3B4SZ17 S3B4SZ17 force-pushed the feat/sydig-runtime-classifier branch 2 times, most recently from 39bd592 to af1c930 Compare July 22, 2025 20:55
@S3B4SZ17 S3B4SZ17 force-pushed the feat/sydig-runtime-classifier branch from af1c930 to f04dfe3 Compare July 22, 2025 21:58
Copy link
Collaborator

@Benimanela Benimanela left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @S3B4SZ17, Thank you for the work on this contribution. The implementation looks good overall.

General

  • Please run demisto-sdk format on all files to ensure consistency with XSOAR standards.

Incident Fields

  • Avoid changing the type of existing incident fields. This introduces breaking changes and may cause issues for users.
  • Use common fields where possible instead of creating new ones. For example:
    • Use the common Event ID field instead of creating a new Sysdig Event ID.
    • Use the common Category field instead of Sysdig Category.

Let me know once you've addressed the feedback so I can review again!

@merit-maita
Copy link
Contributor

@S3B4SZ17 any update?

@merit-maita merit-maita added the pending-contributor The PR is pending the response of its creator label Aug 17, 2025
@merit-maita
Copy link
Contributor

@S3B4SZ17 i'll close the pr for lack of update, once you have some update feel free to reopen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! External PR Partner Support Level Indicates that the contribution is for Partner supported pack Partner Partner-Approved pending-contributor The PR is pending the response of its creator Security Review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants