-
Notifications
You must be signed in to change notification settings - Fork 1.8k
Updating Sysdig Classifier, Incident fields and Layout #40690
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating Sysdig Classifier, Incident fields and Layout #40690
Conversation
Signed-off-by: S3B4SZ17 <[email protected]>
Thank you for your contribution. Your generosity and caring are unrivaled! Make sure to register your contribution by filling the Contribution Registration form, so our content wizard @YaelShamai will know the proposed changes are ready to be reviewed. |
39bd592
to
af1c930
Compare
Signed-off-by: S3B4SZ17 <[email protected]>
af1c930
to
f04dfe3
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @S3B4SZ17, Thank you for the work on this contribution. The implementation looks good overall.
General
- Please run
demisto-sdk format
on all files to ensure consistency with XSOAR standards.
Incident Fields
- Avoid changing the type of existing incident fields. This introduces breaking changes and may cause issues for users.
- Use common fields where possible instead of creating new ones. For example:
- Use the common
Event ID
field instead of creating a newSysdig Event ID
. - Use the common
Category
field instead ofSysdig Category
.
- Use the common
Let me know once you've addressed the feedback so I can review again!
@S3B4SZ17 any update? |
@S3B4SZ17 i'll close the pr for lack of update, once you have some update feel free to reopen |
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Description
Updating the Sysdig default Classifier, Incident fields and Layout
Updated the overall docs and release notes to reflect current state and changes
Must have