Skip to content

Conversation

@BarGali
Copy link
Contributor

@BarGali BarGali commented Jul 23, 2025

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

fixes: https://jira-dc.paloaltonetworks.com/browse/CIAC-14060

Description

Deleted logs that contain params.

Must have

  • Tests
  • Documentation

@BarGali BarGali self-assigned this Jul 23, 2025
@github-actions
Copy link

Your contributed Gem pack has been modified on files:

Packs/Gem/Integrations/Gem/Gem.py
Please review the changes here

@BarGali BarGali requested a review from ShacharKidor July 23, 2025 09:24
@github-actions
Copy link

github-actions bot commented Jul 23, 2025

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CybleEventsV2/Integrations/CybleEventsV2
   CybleEventsV2.py64216075%143–145, 148–150, 156–158, 166, 168–169, 234–235, 257, 265–267, 310, 316–317, 320, 328–329, 378–380, 393–395, 404–409, 416, 424–426, 463, 465–468, 474, 477–478, 510–512, 514, 533–535, 548, 558, 560, 566, 600, 705–706, 774, 803, 865–866, 900–902, 904–908, 911–912, 914, 916, 918, 920–921, 923, 935, 937–938, 942–943, 945, 956–957, 960, 971, 991–992, 1051, 1061, 1067, 1121, 1131–1132, 1147, 1155, 1157, 1162–1163, 1177–1178, 1291–1292, 1324–1334, 1336–1338, 1340–1342, 1344–1345, 1347–1348, 1352–1353, 1355–1359, 1361–1363, 1365–1366, 1368–1372, 1374–1376, 1379, 1388–1390, 1396–1398, 1403, 1405–1406
Packs/Gem/Integrations/Gem
   Gem.py3368774%55–56, 75–76, 78, 80–81, 121–123, 130, 137, 139, 141, 143, 227, 229–230, 243, 246, 272, 274, 307–309, 317, 320–321, 642, 678–681, 683, 1116–1118, 1120, 1122–1124, 1126, 1128, 1130–1160, 1162, 1165, 1167–1169, 1171, 1178–1179, 1181, 1184, 1187, 1190–1191
Packs/QutteraWebsiteMalwareScanner/Integrations/QutteraWebsiteMalwareScanner
   QutteraWebsiteMalwareScanner.py851878%20–22, 34, 42–43, 46, 138, 148–152, 181, 195–198
TOTAL106326575% 

Tests Skipped Failures Errors Time
126 0 💤 0 ❌ 0 🔥 12.257s ⏱️

Copy link
Contributor

@ShacharKidor ShacharKidor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @BarGali,
Looks good.
Please add release notes and bump the pack version of each pack.

Copy link
Contributor

@DeanArbel DeanArbel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Let's wait until next week for the partners to allow partners to review this before it's merged.

@DeanArbel DeanArbel added the ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines label Jul 23, 2025
@content-bot
Copy link
Collaborator

This PR was automatically updated by a GitHub Action

  • Gem pack version was bumped to 1.0.7.

To stop automatic version bumps, add the ignore-auto-bump-version label to the github PR.

@content-bot
Copy link
Collaborator

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

Copy link
Contributor

@richardbluestone richardbluestone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs review done

@BarGali BarGali merged commit a439fb4 into master Jul 27, 2025
21 of 22 checks passed
@BarGali BarGali deleted the bg-xsoar-debug-log branch July 27, 2025 13:43
@DeanArbel
Copy link
Contributor

I have approved @BarGali to merge this PR without partner approval, as it makes no changes to the behavior of the integrations, while removing sensitive info from the logs.

xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 17, 2025
* delete logs

* resolve-conflicts

* delete duplication from merge

* add RN

* Update Packs/CybleEventsV2/ReleaseNotes/1_1_2.md

Co-authored-by: Shachar Kidor <[email protected]>

* Update Packs/Gem/ReleaseNotes/1_0_6.md

Co-authored-by: Shachar Kidor <[email protected]>

* Update Packs/QutteraWebsiteMalwareScanner/ReleaseNotes/1_0_21.md

Co-authored-by: Shachar Kidor <[email protected]>

* Bump pack from version Gem to 1.0.7.

* fixes for pre-commit

* fixes for pre-commit

---------

Co-authored-by: Shachar Kidor <[email protected]>
Co-authored-by: Content Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-approved ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants