-
Notifications
You must be signed in to change notification settings - Fork 1.8k
XSUP-53101 #40703
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XSUP-53101 #40703
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Job!
Please add UT.
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py
Outdated
Show resolved
Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py
Outdated
Show resolved
Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully last notes.
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py
Outdated
Show resolved
Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon.py
Outdated
Show resolved
Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon_test.py
Show resolved
Hide resolved
Packs/CrowdStrikeFalcon/Integrations/CrowdStrikeFalcon/CrowdStrikeFalcon_test.py
Show resolved
Hide resolved
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
* add logs * Possible fix * pre-commit * ruff * small fixes * ruff * rn * Docker image * Update Packs/CrowdStrikeFalcon/ReleaseNotes/2_3_3.md Co-authored-by: Arad Carmi <[email protected]> * Address CR * UT * ruff * RN Fix * RN * UT * Fix UT --------- Co-authored-by: Arad Carmi <[email protected]>
Status
Related Issues
fixes: https://jira-dc.paloaltonetworks.com/browse/XSUP-53101
Description
This PR adds a client-side filter to handle the CrowdStrike Falcon API returning incidents older than the specified
fetch_time
. This patch ensures we only process incidents from the correct time period by filtering out the incorrect, older data after it's received from the API.Must have