Skip to content

Conversation

@content-bot
Copy link
Collaborator

Original External PR

external pull request

Contributor

@zdrouse

…gination support.

Contributing to Cortex XSOAR Content

Make sure to register your contribution by filling the contribution registration form

The Pull Request will be reviewed only after the contribution registration form is filled.

Status

  • In Progress
  • Ready
  • In Hold - (Reason for hold)

Related Issues

Currently, asm-list-external-websites can only ever retrieve the first 500 websites and organizations have way more than that.

Description

Update asm-list-external-websites command to allow for pagination of requests.

API Reference: https://docs-cortex.paloaltonetworks.com/r/Cortex-Xpanse-REST-API/Get-All-Websites

Must have

  • Tests
  • Documentation

#40140)

* Update Cortex Xpanse asm-list-external-websites command to include pagination support.

* adjust Context Outputs for Command Results to include a new object for ExternalWebsiteReply that contains contextual information about the request for external websites.

* added context path output for the NextPageToken underneath ExternalWebsitReply

* added release notes

* introduced a new CommandResults object for asm-list-external-websites since we are unable to change existing functionality of outputs_prefix of the original CommandResults. The new CommandResults object provides an additional about with context information about the request including next page token for pagination, the total results and the result count from the request.   CommandResults is also using  so that context is overwritten with the most recent command execution per recommended usage of .

* change arg gets to use double quotes

* changes requested to test file and docstring for type checking

* update release note md version to 1_2_11

* modify version in pack_metadata.json

* Apply suggestions from doc review

Co-authored-by: julieschwartz18 <[email protected]>

* Bump version

---------

Co-authored-by: cah-zachary-rouse <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Co-authored-by: julieschwartz18 <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
@content-bot content-bot added Contribution Thank you! Contributions are always welcome! docs-approved Contribution Form Filled Whether contribution form filled or not. Community Xsoar Support Level Indicates that the contribution is for XSOAR supported pack Internal PR ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines labels Jul 23, 2025
@content-bot content-bot requested a review from itssapir July 23, 2025 13:53
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
Packs/CortexXpanse/Integrations/CortexXpanse
   CortexXpanse.py6099983%333–338, 340–341, 343–345, 347–348, 431, 433, 447, 451, 455, 457–458, 469–470, 479, 483–484, 491, 525, 529, 531, 565, 625, 759, 802, 804, 806, 844, 847, 883, 886, 922, 925, 961, 964, 1016, 1018, 1033, 1037, 1042, 1051, 1092, 1141, 1147, 1149, 1175, 1221, 1224, 1226, 1231, 1233, 1235–1236, 1238, 1277, 1280, 1285, 1341, 1350, 1354, 1363, 1426, 1429, 1448, 1511–1512, 1514–1519, 1521–1523, 1533–1535, 1537–1538, 1583–1586, 1612, 1614, 1624, 1626, 1630, 1632–1633
TOTAL6099983% 

Tests Skipped Failures Errors Time
41 0 💤 0 ❌ 0 🔥 3.567s ⏱️

@content-bot
Copy link
Collaborator Author

Validate summary
The following errors were thrown as a part of this pr: .
If the AG100 validation in the pre-commit GitHub Action fails, the pull request cannot be force-merged.

Verdict: PR can be force merged from validate perspective? ✅

@itssapir itssapir merged commit 2d1577f into master Jul 24, 2025
48 checks passed
@itssapir itssapir deleted the contrib/zdrouse_zdrouse branch July 24, 2025 07:50
TOUFIKIzakarya pushed a commit to TOUFIKIzakarya/content that referenced this pull request Jul 24, 2025
demisto#40140) (demisto#40707)

* Update Cortex Xpanse asm-list-external-websites command to include pagination support.

* adjust Context Outputs for Command Results to include a new object for ExternalWebsiteReply that contains contextual information about the request for external websites.

* added context path output for the NextPageToken underneath ExternalWebsitReply

* added release notes

* introduced a new CommandResults object for asm-list-external-websites since we are unable to change existing functionality of outputs_prefix of the original CommandResults. The new CommandResults object provides an additional about with context information about the request including next page token for pagination, the total results and the result count from the request.   CommandResults is also using  so that context is overwritten with the most recent command execution per recommended usage of .

* change arg gets to use double quotes

* changes requested to test file and docstring for type checking

* update release note md version to 1_2_11

* modify version in pack_metadata.json

* Apply suggestions from doc review



* Bump version

---------

Co-authored-by: zdrouse <[email protected]>
Co-authored-by: cah-zachary-rouse <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Co-authored-by: julieschwartz18 <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
xsoar-bot pushed a commit to xsoar-contrib/content that referenced this pull request Sep 17, 2025
demisto#40140) (demisto#40707)

* Update Cortex Xpanse asm-list-external-websites command to include pagination support.

* adjust Context Outputs for Command Results to include a new object for ExternalWebsiteReply that contains contextual information about the request for external websites.

* added context path output for the NextPageToken underneath ExternalWebsitReply

* added release notes

* introduced a new CommandResults object for asm-list-external-websites since we are unable to change existing functionality of outputs_prefix of the original CommandResults. The new CommandResults object provides an additional about with context information about the request including next page token for pagination, the total results and the result count from the request.   CommandResults is also using  so that context is overwritten with the most recent command execution per recommended usage of .

* change arg gets to use double quotes

* changes requested to test file and docstring for type checking

* update release note md version to 1_2_11

* modify version in pack_metadata.json

* Apply suggestions from doc review



* Bump version

---------

Co-authored-by: zdrouse <[email protected]>
Co-authored-by: cah-zachary-rouse <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Co-authored-by: julieschwartz18 <[email protected]>
Co-authored-by: Sapir Malka <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Community Contribution Form Filled Whether contribution form filled or not. Contribution Thank you! Contributions are always welcome! docs-approved Internal PR ready-for-pipeline-running Whether the pr is ready for running the whole pipeline, including testing on SAAS machines Xsoar Support Level Indicates that the contribution is for XSOAR supported pack

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants