-
Notifications
You must be signed in to change notification settings - Fork 1.9k
Update Cortex Xpanse asm-list-external-websites command to include pa… #40707
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
#40140) * Update Cortex Xpanse asm-list-external-websites command to include pagination support. * adjust Context Outputs for Command Results to include a new object for ExternalWebsiteReply that contains contextual information about the request for external websites. * added context path output for the NextPageToken underneath ExternalWebsitReply * added release notes * introduced a new CommandResults object for asm-list-external-websites since we are unable to change existing functionality of outputs_prefix of the original CommandResults. The new CommandResults object provides an additional about with context information about the request including next page token for pagination, the total results and the result count from the request. CommandResults is also using so that context is overwritten with the most recent command execution per recommended usage of . * change arg gets to use double quotes * changes requested to test file and docstring for type checking * update release note md version to 1_2_11 * modify version in pack_metadata.json * Apply suggestions from doc review Co-authored-by: julieschwartz18 <[email protected]> * Bump version --------- Co-authored-by: cah-zachary-rouse <[email protected]> Co-authored-by: Sapir Malka <[email protected]> Co-authored-by: julieschwartz18 <[email protected]> Co-authored-by: Sapir Malka <[email protected]>
Coverage Report
|
||||||||||||||||||||||||||||||
Collaborator
Author
|
Validate summary Verdict: PR can be force merged from validate perspective? ✅ |
itssapir
approved these changes
Jul 24, 2025
TOUFIKIzakarya
pushed a commit
to TOUFIKIzakarya/content
that referenced
this pull request
Jul 24, 2025
demisto#40140) (demisto#40707) * Update Cortex Xpanse asm-list-external-websites command to include pagination support. * adjust Context Outputs for Command Results to include a new object for ExternalWebsiteReply that contains contextual information about the request for external websites. * added context path output for the NextPageToken underneath ExternalWebsitReply * added release notes * introduced a new CommandResults object for asm-list-external-websites since we are unable to change existing functionality of outputs_prefix of the original CommandResults. The new CommandResults object provides an additional about with context information about the request including next page token for pagination, the total results and the result count from the request. CommandResults is also using so that context is overwritten with the most recent command execution per recommended usage of . * change arg gets to use double quotes * changes requested to test file and docstring for type checking * update release note md version to 1_2_11 * modify version in pack_metadata.json * Apply suggestions from doc review * Bump version --------- Co-authored-by: zdrouse <[email protected]> Co-authored-by: cah-zachary-rouse <[email protected]> Co-authored-by: Sapir Malka <[email protected]> Co-authored-by: julieschwartz18 <[email protected]> Co-authored-by: Sapir Malka <[email protected]>
xsoar-bot
pushed a commit
to xsoar-contrib/content
that referenced
this pull request
Sep 17, 2025
demisto#40140) (demisto#40707) * Update Cortex Xpanse asm-list-external-websites command to include pagination support. * adjust Context Outputs for Command Results to include a new object for ExternalWebsiteReply that contains contextual information about the request for external websites. * added context path output for the NextPageToken underneath ExternalWebsitReply * added release notes * introduced a new CommandResults object for asm-list-external-websites since we are unable to change existing functionality of outputs_prefix of the original CommandResults. The new CommandResults object provides an additional about with context information about the request including next page token for pagination, the total results and the result count from the request. CommandResults is also using so that context is overwritten with the most recent command execution per recommended usage of . * change arg gets to use double quotes * changes requested to test file and docstring for type checking * update release note md version to 1_2_11 * modify version in pack_metadata.json * Apply suggestions from doc review * Bump version --------- Co-authored-by: zdrouse <[email protected]> Co-authored-by: cah-zachary-rouse <[email protected]> Co-authored-by: Sapir Malka <[email protected]> Co-authored-by: julieschwartz18 <[email protected]> Co-authored-by: Sapir Malka <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Community
Contribution Form Filled
Whether contribution form filled or not.
Contribution
Thank you! Contributions are always welcome!
docs-approved
Internal PR
ready-for-pipeline-running
Whether the pr is ready for running the whole pipeline, including testing on SAAS machines
Xsoar Support Level
Indicates that the contribution is for XSOAR supported pack
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original External PR
external pull request
Contributor
@zdrouse
…gination support.
Contributing to Cortex XSOAR Content
Make sure to register your contribution by filling the contribution registration form
The Pull Request will be reviewed only after the contribution registration form is filled.
Status
Related Issues
Currently, asm-list-external-websites can only ever retrieve the first 500 websites and organizations have way more than that.
Description
Update asm-list-external-websites command to allow for pagination of requests.
API Reference: https://docs-cortex.paloaltonetworks.com/r/Cortex-Xpanse-REST-API/Get-All-Websites
Must have