Open
Conversation
Collaborator
|
I'll take a look at it during the week, thanks. ^-^ |
denisidoro
approved these changes
Apr 2, 2026
Owner
denisidoro
left a comment
There was a problem hiding this comment.
LGTM, but I'll let Alexis merge it
alexis-opolka
approved these changes
Apr 3, 2026
Collaborator
alexis-opolka
left a comment
There was a problem hiding this comment.
Sorry for the wait, it also LGTM, I just had a quick question about the paths handling.
| } | ||
|
|
||
| #[cfg(target_family = "windows")] | ||
| pub fn exe_string() -> String { |
Collaborator
There was a problem hiding this comment.
Just a question on that function, can't we use Pathlib internal paths handling?
What I'm talking about: https://doc.rust-lang.org/std/path/struct.Path.html
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are several bash environments available on Windows, including MSYS2's bash, Git Bash, and w64devkit's bash.
This change makes these bash available in navi.
Config.yaml settings for using Git Bash.
Before:

After:
