Skip to content

Make bash available on Windows#1016

Open
kit494way wants to merge 1 commit intodenisidoro:masterfrom
kit494way:bash-on-windows
Open

Make bash available on Windows#1016
kit494way wants to merge 1 commit intodenisidoro:masterfrom
kit494way:bash-on-windows

Conversation

@kit494way
Copy link
Copy Markdown
Contributor

@kit494way kit494way commented Mar 22, 2026

There are several bash environments available on Windows, including MSYS2's bash, Git Bash, and w64devkit's bash.
This change makes these bash available in navi.

Config.yaml settings for using Git Bash.

shell:
  command: "\"C:/Program Files/Git/bin/bash.exe\""
  finder_command: "C:/Program Files/Git/bin/bash.exe"
  forward_slash_path: true

Before:
スクリーンショット 2026-03-22 132639

After:
スクリーンショット 2026-03-22 132724

@alexis-opolka
Copy link
Copy Markdown
Collaborator

I'll take a look at it during the week, thanks. ^-^

Copy link
Copy Markdown
Owner

@denisidoro denisidoro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'll let Alexis merge it

Copy link
Copy Markdown
Collaborator

@alexis-opolka alexis-opolka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry for the wait, it also LGTM, I just had a quick question about the paths handling.

}

#[cfg(target_family = "windows")]
pub fn exe_string() -> String {
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question on that function, can't we use Pathlib internal paths handling?

What I'm talking about: https://doc.rust-lang.org/std/path/struct.Path.html

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants