Skip to content

BREAKING(cli/unstable): rename refreshMilliseconds to interval#7094

Open
timreichen wants to merge 2 commits intodenoland:mainfrom
timreichen:cli-progress-bar-interval
Open

BREAKING(cli/unstable): rename refreshMilliseconds to interval#7094
timreichen wants to merge 2 commits intodenoland:mainfrom
timreichen:cli-progress-bar-interval

Conversation

@timreichen
Copy link
Copy Markdown
Contributor

This PR renames ProgressBarOptions.refreshMilliseconds to ProgressBarOptions.interval in order to align with PollOptions.interval and SpinnerOptions.interval.

@github-actions github-actions Bot added the cli label Apr 13, 2026
@timreichen timreichen changed the title refactor(cli): rename refreshMilliseconds to interval BREAKING(cli/unstable): rename refreshMilliseconds to interval Apr 13, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.59%. Comparing base (a3a6ef6) to head (89cff88).
⚠️ Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7094      +/-   ##
==========================================
+ Coverage   94.43%   94.59%   +0.16%     
==========================================
  Files         630      632       +2     
  Lines       50566    51780    +1214     
  Branches     8969     9324     +355     
==========================================
+ Hits        47750    48980    +1230     
+ Misses       2247     2225      -22     
- Partials      569      575       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Member

@bartlomieju bartlomieju left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The @default tag was changed to {75} (matching Spinner) but the destructuring default is still interval = 1000. These should agree — 1000ms is probably the right default for a progress bar (once-per-second updates), so the tag should stay @default {1000}.

Updated default interval for progress bar from 75ms to 1000ms.
@timreichen
Copy link
Copy Markdown
Contributor Author

The @default tag was changed to {75} (matching Spinner) but the destructuring default is still interval = 1000. These should agree — 1000ms is probably the right default for a progress bar (once-per-second updates), so the tag should stay @default {1000}.

Good catch, fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants