BREAKING(cli/unstable): rename refreshMilliseconds to interval#7094
BREAKING(cli/unstable): rename refreshMilliseconds to interval#7094timreichen wants to merge 2 commits intodenoland:mainfrom
refreshMilliseconds to interval#7094Conversation
refreshMilliseconds to intervalrefreshMilliseconds to interval
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7094 +/- ##
==========================================
+ Coverage 94.43% 94.59% +0.16%
==========================================
Files 630 632 +2
Lines 50566 51780 +1214
Branches 8969 9324 +355
==========================================
+ Hits 47750 48980 +1230
+ Misses 2247 2225 -22
- Partials 569 575 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bartlomieju
left a comment
There was a problem hiding this comment.
The @default tag was changed to {75} (matching Spinner) but the destructuring default is still interval = 1000. These should agree — 1000ms is probably the right default for a progress bar (once-per-second updates), so the tag should stay @default {1000}.
Updated default interval for progress bar from 75ms to 1000ms.
Good catch, fixed. |
This PR renames
ProgressBarOptions.refreshMillisecondstoProgressBarOptions.intervalin order to align withPollOptions.intervalandSpinnerOptions.interval.