refactor(internal): tidy up diffStr inner loop#7109
Open
tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Open
refactor(internal): tidy up diffStr inner loop#7109tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
diffStr inner loop#7109tomas-zijdemans wants to merge 2 commits intodenoland:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7109 +/- ##
=======================================
Coverage 94.60% 94.60%
=======================================
Files 633 633
Lines 51777 51777
Branches 9324 9325 +1
=======================================
Hits 48986 48986
Misses 2216 2216
Partials 575 575 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Three small structural cleanups in the word-diff inner loop of
diffStrshift(removes an O(n²) pattern and the in-place mutation)aTokens = tokenize(a.value, true)above the inner whilearray+.reverse()with a ternary ondiff(...). Drops theas [string[], string[]]castBenhmarks show only modest gains.