feat: implement bottom navigation with haptic feedback and safe area support - #77
Merged
Conversation
Salvation-sub
requested review from
haejinyun,
javadocq and
soosoo22
as code owners
November 2, 2025 03:24
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
javadocq
approved these changes
Nov 3, 2025
javadocq
left a comment
javadocq
left a comment
Contributor
There was a problem hiding this comment.
웹과 앱 safeareaview까지 둘 다 적용이 되게 하는 거 완전 깔끔한 것 같습니다!
바텀 내브도 변경하시느라 고생 많으셨습니다!
javadocq
reviewed
Nov 3, 2025
|
|
||
| const handleNavigation = async (path: string) => { | ||
| await triggerHaptic(); | ||
| router.replace(path as any); |
Contributor
There was a problem hiding this comment.
사용자 입장에서 탭 이동은 독립적인 이동으로 간주할 것 같은데 replace로 가면 UX적으로 혼동이 있지 않을까? 싶은데 어떠신가용?
Collaborator
Author
There was a problem hiding this comment.
맞습니당! 생각해보니깐 그렇네요! 해당 내용 반영했습니다!!
haejinyun
approved these changes
Nov 4, 2025
| export const AUTH_CONFIG = { | ||
| // 인증이 필요한 경로들 | ||
| PROTECTED_ROUTES: ["/onboarding"] as const, | ||
| PROTECTED_ROUTES: ["/onboarding", "/mypage"] as const, |
Collaborator
Author
There was a problem hiding this comment.
반영 완료했습니당!! 나이스 캐취!!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 PR Title
feat: implement bottom navigation with haptic feedback and safe area support
📌 Work Description
✅ Checklist
🚀 How to Test (Optional)
Web
pnpm devin/webdirectory/homeor/mapReact Native
app/app/index.tsxnpx expo startin/appdirectory