Conversation
* WIP: Share progress, needs refactoring
* add shared RoundedSelectBox * add shared constant STATIONS
haejinyun
requested review from
Salvation-sub,
javadocq and
soosoo22
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
soosoo22
approved these changes
Nov 13, 2025
Member
soosoo22
left a comment
soosoo22
left a comment
There was a problem hiding this comment.
필터 기능이 홈 - 지도 페이지 일관되게 동작하도록 잘 처리해주셨네요! 👏👏👏
로컬에서 확인했을 때 문제없이 잘 동작합니다! 수고하셨어용!
| max: number; | ||
| }; | ||
| honbobLevel: number; | ||
| honbobLevel?: number[]; |
Contributor
Author
There was a problem hiding this comment.
이 부분은 dto에 s가빠져있어서 고민히다가 다 단수로 바꿨습니다.. BE랑 이야기해서 수정해야할 것 같아요.
Comment on lines
+59
to
+66
| <div | ||
| className="fixed right-5 z-40" | ||
| style={{ | ||
| top: "calc(84px + env(safe-area-inset-top))", | ||
| }} | ||
| > | ||
| <LevelFilterButton honbobLevel={levelDisplayValue} onClick={openFilter} /> | ||
| </div> |
Comment on lines
+17
to
+31
| export function useStoreListQuery({ | ||
| filters, | ||
| center, | ||
| bounds, | ||
| limit = 30, | ||
| station, | ||
| }: UseStoreListQueryParams) { | ||
| const hasGeoBounds = !!bounds; | ||
|
|
||
| const generateQueryKey = () => { | ||
| if (hasGeoBounds && bounds) { | ||
| return queryKeys.STORE_LIST_BY_BOUNDS(filters, { bounds, center }); | ||
| } | ||
| return queryKeys.STORE_LIST(station || "default", filters); | ||
| }; |
Member
There was a problem hiding this comment.
오! useSToreListQuery훅을 홈에서도 재사용하기 위해 키 분리하는 거 좋네용!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🔥 PR Title
add new filter ui ux
📌 Work Description
(we use in /home, /map)
sortBy✅ Checklist
📸 Screenshots (Optional)
🚀 How to Test (Optional)
💡 Notes / Discussion Points (Optional)