Skip to content

fix: revert font-family on heading elements#2315

Merged
anastasialanz merged 1 commit intodevelopfrom
fix--revert-font-family-on-heading
Apr 8, 2026
Merged

fix: revert font-family on heading elements#2315
anastasialanz merged 1 commit intodevelopfrom
fix--revert-font-family-on-heading

Conversation

@anastasialanz
Copy link
Copy Markdown
Collaborator

Summary

  • Removes the --heading-font-family CSS custom property and font-family rule on heading elements introduced in feat: create a density-compact preset #2287
  • Headings will now inherit font-family from body instead of being explicitly set via a custom property

Test plan

  • Verify heading elements render with the correct inherited font-family
  • Confirm no visual regressions in light and dark themes

@anastasialanz anastasialanz requested a review from a team as a code owner April 8, 2026 16:07
Copilot AI review requested due to automatic review settings April 8, 2026 16:07
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reverts the heading-specific font-family override that was introduced alongside density presets, returning headings to inheriting typography from body while keeping heading color theming via --heading-text-color.

Changes:

  • Removes the --heading-font-family CSS custom property from :root.
  • Removes the font-family: var(--heading-font-family) rule from heading selectors so headings inherit from body.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copy link
Copy Markdown
Contributor

@Bracciata Bracciata left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aws-amplify-us-east-1
Copy link
Copy Markdown

This pull request is automatically being deployed by Amplify Hosting (learn more).

Access this pull request here: https://pr-2315.d15792l1n26ww3.amplifyapp.com

@anastasialanz anastasialanz merged commit 290ddae into develop Apr 8, 2026
12 checks passed
@anastasialanz anastasialanz deleted the fix--revert-font-family-on-heading branch April 8, 2026 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants