Skip to content

feat: add dynamic logos #3432

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
itpick wants to merge 2 commits into from
Closed

feat: add dynamic logos #3432

itpick wants to merge 2 commits into from

Conversation

@itpick
Copy link

@itpick itpick commented Jul 2, 2025

Add feature to modify displayed logo in K9s console from skins

copy of this but no one is fixing the linting so I just did.
see details here:
#3225

@itpick
Copy link
Author

itpick commented Jul 2, 2025

@derailed - please approve for workflows, thanks!

@itpick itpick mentioned this pull request Jul 2, 2025
Closed
2 tasks
@itpick
Copy link
Author

itpick commented Jul 7, 2025

@derailed approval again please

@itpick
Copy link
Author

itpick commented Jul 10, 2025

@derailed sorry, please again

@feteu
Copy link

feteu commented Aug 1, 2025

@derailed any chance of looking into this.
Many thanks already in advance. Happy to help in case something would not work out,

@itpick
Copy link
Author

itpick commented Aug 18, 2025 •
edited
Loading

working on fixing now, rebased

@itpick itpick force-pushed the Feature/dynamic-logo branch from 48f86f4 to f56bcec Compare August 18, 2025 14:27
@itpick
Copy link
Author

itpick commented Aug 18, 2025

@derailed please approve workflows. There is no pre-commit file in this repo so if you like line endings to have a space almost every file would be touched. About to push up another change.

@itpick
Copy link
Author

itpick commented Aug 18, 2025

After adding local .pre-commit-config.yaml we have some trailing line-endings needed and some extra spaces in various places cleaned up. Adding a local pre-commit within the repo will help ensure confidence when someone pushes up an MR, i won't fail the pipeline.

@itpick
Copy link
Author

itpick commented Aug 18, 2025

@derailed
please approve pipelines, thank you so much!

@itpick
Copy link
Author

itpick commented Aug 18, 2025 

  - id: trailing-whitespace
  - id: end-of-file-fixer
  
  both of those were run that is why so many files were touched.  But now it is cleaner!
  @derailed

@itpick
Copy link
Author

itpick commented Aug 18, 2025

@derailed - right here thanks!

@itpick
Copy link
Author

itpick commented Aug 19, 2025

@derailed - approval pretty please

@itpick
Copy link
Author

itpick commented Aug 20, 2025

@fengye87 - can you approve the workflows?

@fengye87
Copy link
Contributor

fengye87 commented Aug 21, 2025

@drduker I'm afraid I don't have the permissions

@itpick
Copy link
Author

itpick commented Aug 21, 2025

@derailed - i am so sorry I'm continuing to ping you. Hoping one of these shows up in your notifications feed.

@itpick
Copy link
Author

itpick commented Aug 22, 2025

@derailed will this work or do want some changes?

@feteu
Copy link

feteu commented Aug 23, 2025 •
edited
Loading

@derailed would be amazing if this could be rolled out soon. Really looking forward to this.

@itpick
Copy link
Author

itpick commented Sep 2, 2025

@derailed please approve workflow run

@github-actions
Copy link

github-actions bot commented Oct 3, 2025

This PR is stale because it has been open for 30 days with no activity.

@github-actions github-actions bot added the stale label Oct 3, 2025
@itpick
Copy link
Author

itpick commented Oct 4, 2025

@derailed - 👋

@github-actions github-actions bot removed the stale label Oct 5, 2025
@itpick itpick force-pushed the Feature/dynamic-logo branch from 052ac8c to 780b5fa Compare October 13, 2025 22:49
@feteu
Copy link

feteu commented Oct 14, 2025 •
edited
Loading

Any update on this issue, happy to contribute if something would be missing.
@derailed

@itpick itpick force-pushed the Feature/dynamic-logo branch from 7c20b8b to fbfdd2c Compare December 6, 2025 04:06
@itpick
feat: add dynamic logos
47e71b3 
Add feature to modify displayed logo in K9s console from skins.
Users can now customize the logo via the logoUrl field in skin
configuration, supporting both file:// and http(s):// URLs.

- Add logoUrl field to Body struct in styles
- Implement GetLogo function to fetch logos from URL or file
- Add example logo assets (dev, prod, rc, sandbox)
- Update logo display width from 26 to 40 characters
@itpick itpick force-pushed the Feature/dynamic-logo branch from fbfdd2c to 47e71b3 Compare December 6, 2025 04:10
@feteu
Copy link

feteu commented Dec 6, 2025

@derailed 👋🏼

@thepixelabs
Copy link

thepixelabs commented Dec 7, 2025

+1

@itpick
Copy link
Author

itpick commented Dec 9, 2025

potential for getting into v0.50.17?

@feteu
Copy link

feteu commented Dec 20, 2025

@derailed 👋🏼 (any chance to push this?)

@Harriscfn
Copy link

Harriscfn commented Dec 23, 2025

This would be so amazing!

@feteu
Copy link

feteu commented Dec 27, 2025

@derailed 👋🏼 (keeping up the posts, in the hope you'll see it; apologies for bothering)

@sherifabdlnaby
Copy link

sherifabdlnaby commented Jan 11, 2026

As good as this sounds. I think k9s deserve the brand recognition.

@itpick
Copy link
Author

itpick commented Jan 11, 2026 •
edited
Loading

As good as this sounds. I think k9s deserve the brand recognition.

There is still the splash page and the binary is called k9s. Customization of the logo is functional and brings real value.

@derailed
Copy link
Owner

derailed commented Jan 11, 2026

@drduker It looks like we have conflicts. Can you take a peek?

@derailed derailed added needs-tlc Pr needs additional updates in-progress Mark issue as being worked on labels Jan 11, 2026
@itpick
Merge upstream/master and resolve conflict in styles.go
58e02b3 
The upstream added an `invert bool` parameter to `Styles.Load()` while
the branch added `LogoUrl` reset functionality. This merge keeps both
changes.
@itpick
Copy link
Author

itpick commented Jan 12, 2026

@drduker It looks like we have conflicts. Can you take a peek?

Resolved, thanks!

@itpick itpick closed this by deleting the head repository Jan 16, 2026
@mohsenasm
Copy link

mohsenasm commented Jan 31, 2026

Hi @itpick @derailed,
What is the status of this feature? Did it get merged?
There are also six other closed PRs related to this feature.

I can also help with code or documentation if the work is not done yet.

@feteu
Copy link

feteu commented Feb 5, 2026

Happy to help out as well in case something is missing. @derailed

@mohsenasm
Copy link

mohsenasm commented Feb 8, 2026 •
edited
Loading

Hi all,

Because I couldn't find the code for this PR, I started a fork that dynamically sets an ASCII art logo based on the cluster name. The cluster name will be loaded from the .kube/config file and will replace the logo. It will also update when the context changes.

It's working for me, and I may also send a PR later.

https://github.com/mohsenasm/k9s

Screenshot 2026-02-08 at 5 55 54 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

in-progress Mark issue as being worked on needs-tlc Pr needs additional updates

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

@itpick @feteu @fengye87 @thepixelabs @Harriscfn @sherifabdlnaby @derailed @mohsenasm