fix: Editing a single Namespace opens the editor with a list of all Namespaces #3760
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When editing a resource with a path that ends with "/" (e.g., "-/"), the resource name extracted by client.Namespaced() is empty. This caused the kubectl edit command to be constructed without a resource name, resulting in editing ALL resources of that type instead of a single resource. This fix adds a check to ensure the resource name is not empty before proceeding with the edit command. If the name is empty, an error is returned to prevent the unintended behavior. Fixes derailed#3708 Signed-off-by: majiayu000 <[email protected]>
Owner
|
@majiayu000 Thank you for this update! Tho I don't think this fixes the issue vs just flagging the condition. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3708
Changes
When editing a cluster-scoped resource like Namespace, the edit command would previously run without a specific resource name if the path parsing resulted in an empty name, causing kubectl to open all resources instead of the selected one.