Skip to content

Generate new randomness r for payload, distinct from amount#179

Open
Slixe wants to merge 6 commits intoderoproject:mainfrom
Slixe:fix-privacy-issue
Open

Generate new randomness r for payload, distinct from amount#179
Slixe wants to merge 6 commits intoderoproject:mainfrom
Slixe:fix-privacy-issue

Conversation

@Slixe
Copy link
Contributor

@Slixe Slixe commented May 20, 2024

Description

This PR is made to fix the privacy issue which allow to brute force and de-anonymize a TX.

What I'm doing is:

  • Generate a new randomness named R

  • Encrypt it using public keys from sender & receiver, and include it as overhead in the payload

  • Generate a shared key from RG (r * G)

  • Encrypt / Decrypt using the shared key

  • Define a new RPC Type to handle it

  • add test for encrypt/decrypt using new method

  • support new format in daemon_communication.go

Fixes # (issue)
Fix the issue #178

Type of change

Please select the right one.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • This will require a HardFork to be enabled

Which part is impacted ?

  • Wallet
  • Daemon
  • Miner
  • Explorer
  • Simulator
  • Misc (documentation, comments, text...)

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • My changes generate no new warnings

License

Im am contributing & releasing the code under DERO Research License (which can be found here).

@Slixe Slixe marked this pull request as draft May 20, 2024 20:38
@Slixe Slixe changed the title DRAFT: generate new randomness r for payload, distinct from amount Generate new randomness r for payload, distinct from amount May 24, 2024
@Slixe Slixe marked this pull request as ready for review May 24, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant