Skip to content

Conversation

thiagolunardi
Copy link
Collaborator

This pull request introduces a new DevStore.Infra.Core building block, refactors the database provider and health check infrastructure to reside under this new project, and standardizes NuGet package versioning across the solution. It also updates project references and namespaces to reflect these changes, and simplifies package references in several .csproj files.

Infrastructure Refactoring and Project Structure:

  • Introduced the new DevStore.Infra.Core project, including its .csproj file with relevant package references for databases and health checks. (src/building-blocks/DevStore.Infra.Core/DevStore.Infra.Core.csproj)
  • Moved and renamed all database provider and health check related classes from DevStore.WebAPI.Core to DevStore.Infra.Core, updating namespaces and references accordingly. (src/building-blocks/DevStore.Infra.Core/DatabaseFlavor/*, src/building-blocks/DevStore.Infra.Core/Configuration/GenericHealthCheck.cs) [1] [2] [3] [4] [5]
  • Updated the solution file and project references to include DevStore.Infra.Core. (DevStore.slnx)

Codebase Consistency and Dependency Management:

  • Centralized NuGet package version management using a new Directory.Packages.props file, and removed explicit version numbers from most .csproj files to reference shared versions. (Directory.Packages.props, multiple .csproj files) [1] [2] [3] [4] [5] [6]
  • Updated all relevant code files and using statements to reference the new infrastructure project and namespaces. (src/building-blocks/DevStore.WebAPI.Core/Configuration/ApiCoreConfig.cs, src/web/DevStore.WebApp.Status/Program.cs) [1] [2] [3]

Minor Cleanups and Improvements:

  • Improved documentation and readability in provider configuration and detection methods. (src/building-blocks/DevStore.Infra.Core/DatabaseFlavor/ProviderConfiguration.cs)
  • Added minor formatting and whitespace improvements in various project files. [1] [2] [3] [4] [5]

These changes collectively modernize the infrastructure layer, improve maintainability, and standardize dependency management throughout the solution.

@thiagolunardi thiagolunardi requested a review from Copilot August 11, 2025 09:22
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request introduces centralized package management and refactors infrastructure components by creating a new DevStore.Infra.Core project. The changes consolidate database provider and health check functionality into a dedicated infrastructure layer and standardize NuGet package versioning across the solution.

  • Creates a new DevStore.Infra.Core project to house database provider and health check infrastructure components
  • Implements centralized package version management using Directory.Packages.props
  • Updates project references and namespaces to reflect the new infrastructure organization

Reviewed Changes

Copilot reviewed 15 out of 29 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
Directory.Packages.props Introduces centralized package version management for the entire solution
DevStore.slnx Adds the new infrastructure project to the solution
DevStore.Infra.Core/DevStore.Infra.Core.csproj Creates new infrastructure project with database and health check dependencies
DevStore.Infra.Core/DatabaseFlavor/* Moves database provider classes from WebAPI.Core with updated namespaces
DevStore.Infra.Core/Configuration/GenericHealthCheck.cs Moves health check configuration with updated namespace
DevStore.WebAPI.Core/Configuration/ApiCoreConfig.cs Updates imports to reference new infrastructure project
src/web/DevStore.WebApp.Status/Program.cs Updates namespace references and adds null assertion operator
Multiple .csproj files Removes explicit version numbers to use centralized package management

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants