ci: Add Flake8 linting to notebooks

[EdCaunt]

@ggorman pointed out that you can now Flake8 lint Jupyter Notebooks. We should probably do this.

[mloubout]

I personally wouldn't. Flake8 is really not adapted to notebooks, where readable and potentially longer lines are preferred.

[EdCaunt]

We could always set a custom rule to ignore "line too long"

[EdCaunt]

Looking at it, there are only about 5 "Line too long" warnings in the whole output, and most are only 5 or so characters over.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 87.26%. Comparing base (2f18ab8) to head (be6715a).
⚠️ Report is 1078 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main    #2484      +/-   ##
==========================================
- Coverage   87.26%   87.26%   -0.01%     
==========================================
  Files         238      238              
  Lines       45278    45271       -7     
  Branches     4022     4022              
==========================================
- Hits        39512    39505       -7     
  Misses       5085     5085              
  Partials      681      681              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

[review-notebook-app]

Check out this pull request on 

See visual diffs & provide feedback on Jupyter Notebooks.

---

Powered by ReviewNB

[mloubout]

This diff is way too big for just a few line change. Also those depa should be in requirements-testing.txt not hardcoded in the yaml

[EdCaunt]

This diff is way too big for just a few line change.

Yeah, I messed up adding the changes in one of the notebooks somehow. Will fix in due course

[EdCaunt]

Also those depa should be in requirements-testing.txt not hardcoded in the yaml

I was just going off how the Flake8 workflow already works, can change this

[JDBetteridge]

@EdCaunt are you happy that #2813 supersedes this and we can close?

[EdCaunt]

@JDBetteridge yeah I think so