compiler: Tweak nofuse mode#2790
Closed
FabioLuporini wants to merge 1 commit into
Closed
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2790 +/- ##
==========================================
+ Coverage 82.96% 83.03% +0.06%
==========================================
Files 248 248
Lines 50804 50805 +1
Branches 4479 4479
==========================================
+ Hits 42151 42187 +36
+ Misses 7879 7853 -26
+ Partials 774 765 -9
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
closing because unfortunately it's not that straightforward, there's a subtle issue popping up if I do this |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not straightforwardly testable in OSS (I tried for 10 mins, but didn't come up with anything)
It is tested via PRO though
It's essentially a performance (not correctness!) bug fix: without this tweak, we might place a few more barriers than strictly necessary. Honestly, maybe just 1-2 at worst, and only in rare cases. But still, patched is better