Skip to content

Conversation

@devrahulbanjara
Copy link
Owner

This pull request introduces a new GitHub Actions CI pipeline and refactors several backend API route files for improved readability, consistency, and modern Python typing. The main themes are infrastructure automation and code cleanup, focusing on import ordering, type annotations, and formatting for better maintainability.

Infrastructure:

  • Added .github/workflows/ci.yml to automate backend (Python linting with Ruff) and frontend (ESLint) checks on pushes and pull requests to main/dev branches. This ensures code quality and consistency across the project.

API Route Refactoring:

  • Updated type annotations in API route response models to use Python built-in generics (e.g., list[Type] and dict[str, Type]) instead of List/Dict from typing, providing cleaner and more modern type hints. [1] [2] [3]
  • Improved import ordering and grouping in route files (applications.py, auth.py, jobs.py, profile.py, resume.py) for clarity and PEP8 compliance. [1] [2] [3] F14abb34L1, [4]
  • Reformatted function signatures and argument lists for better readability and consistency, including trailing commas and compact parameter grouping. [1] [2] [3] [4] [5] [6] [7]
  • Improved error handling by formatting HTTPException details for multi-line readability and updating exception blocks for better clarity. [1] [2] [3] [4] [5]

Other Minor Cleanups:

These changes collectively enhance code quality, enforce consistent standards, and add automated checks for future development.

… Gmail integration

- Add Gmail configuration settings (GMAIL_APP_PASSWORD, GMAIL_USER, BOOKING_LINK)
- Create scheduling workflow graph with LangGraph nodes
- Implement email service for sending interview invitations
- Add HTML email templates for candidate notifications
- Export interview_scheduling module from agents package
- Add ruff as dev dependency for linting and formatting
- Create ruff.toml with project-specific configuration
- Enable rules: E, W, F, I (isort), UP, B, SIM
- Configure formatter: double quotes, spaces, docstring-code-format
- Apply ruff check --fix to auto-fix 554 lint issues
- Apply ruff format to standardize code style across 33 files
- Update eslint.config.mjs with rule overrides for existing codebase
- Fix empty interface patterns in input.tsx and label.tsx
- Fix unescaped entities in login page and ErrorBoundary
- Replace <a> with Next.js <Link> in ErrorBoundary
- Fix prefer-const in NeuralIntelligenceSection
- Downgrade strict rules to warnings for gradual improvement
- Run on PRs and pushes to main/dev branches only
- Backend: Ruff linting and format checking
- Frontend: ESLint and production build
- Type checking disabled until TS errors are resolved
@devrahulbanjara devrahulbanjara merged commit e722c5e into dev Dec 6, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants