Skip to content

Conversation

Milias
Copy link

@Milias Milias commented May 26, 2025

What issue type does this pull request address? (keep at least one, remove the others)
/kind enhancement

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
No issue.

Please provide a short message that should be published in the DevSpace release notes
Exposed in the localRegistry configuration resources and annotations of the created Pods.

What else do we need to know?
I am not very familiar with go or this codebase, if you have any suggestions please feel free!

Copy link

netlify bot commented May 26, 2025

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 06fa826
🔍 Latest deploy log https://app.netlify.com/projects/devspace-docs/deploys/6870c36914c1310008dd8683
😎 Deploy Preview https://deploy-preview-2964--devspace-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

dependabot bot and others added 3 commits May 26, 2025 21:46
Bumps [@babel/runtime-corejs3](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime-corejs3) from 7.22.5 to 7.26.10.
- [Release notes](https://github.com/babel/babel/releases)
- [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md)
- [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime-corejs3)

---
updated-dependencies:
- dependency-name: "@babel/runtime-corejs3"
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>
Signed-off-by: Francisco Garcia Florez <[email protected]>
@Milias Milias force-pushed the add-local-registry-resources branch from e59a093 to 4102245 Compare May 26, 2025 19:46
Milias added 3 commits May 26, 2025 21:48
Signed-off-by: Francisco Garcia Florez <[email protected]>
Signed-off-by: Francisco Garcia Florez <[email protected]>
@Milias Milias changed the title Add local registry resources feat(localRegistry): expose pod resources May 26, 2025
@deniseschannon
Copy link

Before we review, would you mind looking at the errors from the failed check for Lint?

https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964

Signed-off-by: Francisco Garcia Florez <[email protected]>
@Milias Milias force-pushed the add-local-registry-resources branch from 30e1bc1 to 9fc56c1 Compare May 30, 2025 22:14
@Milias
Copy link
Author

Milias commented May 30, 2025

Before we review, would you mind looking at the errors from the failed check for Lint?

https://github.com/devspace-sh/devspace/actions/runs/15261087358/job/43202271440?pr=2964

Thanks for the heads up!

I removed those two unused fields, I had to guess a bit because I couldn't easily run the linter locally.

Hopefully that was all :)

@Milias
Copy link
Author

Milias commented Jun 5, 2025

Hello!

I don't know exactly why there is a failing test, doesn't seem related to changes in the PR.

Is there something I could do?

@lizardruss
Copy link
Collaborator

Hello!

I don't know exactly why there is a failing test, doesn't seem related to changes in the PR.

Is there something I could do?

It looks like this was a temporary failure. Could you also rebase your branch against main and push those changes? That will re-run the actions and hopefully they will work this time. fwiw, there's usually a button in GH to re-run, but I don't have that available right now.

@Milias
Copy link
Author

Milias commented Jul 11, 2025

Done!

Let's see if pipelines collaborate :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants