Merged
Conversation
kehiy
changed the title
…ps and add mutex and getters/setters
…ops and add mutex and getters/setters
…of values for mutex safety
SwimmingRieux
force-pushed
the
global_config
branch
from
ef8bcfb to
84b5eb8
Compare
kehiy
reviewed
Mar 25, 2025
Member
|
@SwimmingRieux i think you missed an important part of the global config issue. we don't call the manager for new configurations. manager calls us. we add a new method on delivery/grpc called set config. |
…e related imports
kehiy
reviewed
Mar 26, 2025
kehiy
approved these changes
Mar 26, 2025
Member
|
@SwimmingRieux thank you sadeq. 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
So far, I've added a keeper to store pointers to config parameters that may change at runtime, reorganized package imports to avoid cyclic dependencies, and added mutexes along with getters/setters for concurrency.
Also I'm going to update grpc related logics for updating config parameters at runtime.
Related Issue