Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces migration support, adds reported events functionality, and updates event acceptance rules (including accepting kind 5 and 62 from everyone) while renaming and updating several gRPC service definitions.
- Added new migration proto definitions and server implementation.
- Updated event handling to report events asynchronously and modified error handling in delayed tasks.
- Adjusted gRPC server creation and proto service names across the codebase.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| delivery/websocket/server.go | Removed an unused import |
| delivery/websocket/event_handler.go | Added asynchronous reporting via SendReport and updated event validity checks |
| delivery/grpc/server.go | Updated server struct and constructor parameters; registered migration service |
| delivery/grpc/proto/* | Renamed services and added new migration.proto definitions |
| delivery/grpc/gen/* | Autogenerated file updates reflecting service renames and migration addition |
| config/config.go | Adjusted import ordering |
| cmd/relay/relay.go | Updated parameter passing to grpc.New constructor |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces migration support by adding a new gRPC migration service, enhances event processing in the websocket handler (including support for reported events and accepting event kinds 5 and 62), and refactors several proto service names for consistency. Key changes include:
- Modifications to the websocket event handler to add context timeouts and error reporting via a goroutine.
- Addition of a new migration service and its associated proto definitions and server implementation.
- Changes in gRPC service naming (e.g. ShutdownService → Shutdown, ParametersService → Parameters) and related client/server updates, along with minor refactoring in config and command initialization.
Reviewed Changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| delivery/websocket/server.go | Removed an unnecessary blank import line. |
| delivery/websocket/event_handler.go | Adjusted event validation and added context timeout with concurrent reporting logic. |
| delivery/grpc/server.go | Updated the constructor signature to use value semantics and injected a new migration server. |
| delivery/grpc/proto/*.proto | Renamed service names for consistency. |
| delivery/grpc/migration.go | Added migration service with TODO comments about error handling and event kinds. |
| cmd/relay/relay.go | Changed the parameters passed into grpc.New by dereferencing db and handler. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Related Issue