Skip to content

feat: nip-05 service#83

Merged
kehiy merged 9 commits intomainfrom
feature-nip05
May 16, 2025
Merged

feat: nip-05 service#83
kehiy merged 9 commits intomainfrom
feature-nip05

Conversation

@ZigBalthazar
Copy link
Copy Markdown
Member

No description provided.

@kehiy kehiy requested a review from Copilot May 16, 2025 10:21
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces NIP-05 support by extending the username availability flow to include domain selection, conditionally rendering NIP-05 features, and normalizing SVG props.

  • Extend useCheckAvailability and the availability form to select and resolve domains before checking username availability.
  • Update the Features component to display a new nipData card set when on the /nip05 route.
  • Normalize SVG attribute names to camelCase and add required dependencies (@radix-ui/react-select, nostr-tools).

Reviewed Changes

Copilot reviewed 49 out of 49 changed files in this pull request and generated 7 comments.

Show a summary per file
File Description
src/components/pages/Availability/CheckAvailabity/useCheckAvailability.ts Added inline domainService, updated schema & submission logic to include domain.
src/components/pages/Availability/CheckAvailabity/CheckAvailabilityForm.tsx Implemented domain dropdown with react-query and Controller; updated form layout.
src/components/common/Features/index.tsx Conditionally render nipData vs. relayFeaturesData based on pathname.
src/components/common/Features/data.tsx Added new nipData array for NIP-05 feature cards.
src/assets/icons/**/*.tsx Converted SVG attribute keys (e.g., stop-color) to React-friendly camelCase.
package.json Added dependencies: @radix-ui/react-select, nostr-tools.
index.html Commented out the X-Frame-Options header.
Comments suppressed due to low confidence (1)

src/components/pages/Availability/CheckAvailabity/useCheckAvailability.ts:62

  • The new conflict-handling and domain-resolution branches lack unit or integration tests; consider adding tests to cover these code paths.
if (error.response?.data?.error === "Conflict") {

kehiy and others added 5 commits May 16, 2025 10:43
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ilityForm.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
…ilityForm.tsx

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
@kehiy kehiy merged commit 52b80ae into main May 16, 2025
5 checks passed
@kehiy kehiy deleted the feature-nip05 branch May 16, 2025 10:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants