-
Notifications
You must be signed in to change notification settings - Fork 366
chore: update rust to 1.88.0 #6045
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Run URL: https://github.com/dfinity/ic/actions/runs/16491669432 New container image: |
Run URL: https://github.com/dfinity/ic/actions/runs/16492087374 New container image: |
…e2c8104697f863585ad0ce70aab41f Image tag: 81b0a98486c17991e211deda54c717bfff6427ff14924bf746d5f8fd6cfb9179
…edc2a273a700eabd0670dc489d809c Image tag: 16e06bf3c56bdcc50674a64be074337acee526d41ac785780ae4a9835a6a637b
7ab3bb8
to
6267318
Compare
* Fix `//rs/execution_environment:execution_environment_misc_integration_tests/backtraces_test` tests * Fix `//publish/canisters:sns-governance-canister.wasm.gz_size_check` test * Update benchmark reults
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot, @kpop-dfinity, the FI changes LGTM! The overview table of canbench changes is very helpful!
No canister behavior changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
crypto lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would have probably added an explicit comment whenever added #[allow(clippy::result_large_err)]
, but I'm almost the last to approve, so won't block on that.
LGTM for Utopia
Changes
pedantic
in the cargo clippy, so the problem will eventually go away, but it is still an issue in this version of rust (1.88.0
). See alsouninlined_format_args
should have stayed inpedantic
rust-lang/rust-clippy#15151rs/execution_environment/tests/backtraces.rs
file_size_check
testsBenchmarks updates
//rs/ledger_suite/icrc1/ledger:canbench_u256
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
//rs/ledger_suite/icrc1/ledger:canbench_u64
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change
//rs/nns/governance:governance-canbench
Only significant changes:
ins = instructions, HI = heap_increase, SMI = stable_memory_increase, Δ% = percent change