WIP: stable function upgrade examples #5354
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Base automatically changed from
claudio/stable-functions-merge
to
luc/stable-functions
July 25, 2025 07:06
crusso
reviewed
Jul 25, 2025
| @@ -0,0 +1,14 @@ | |||
| //ENHANCED-ORTHOGONAL-PERSISTENCE-ONLY | |||
| //SKIP ic-ref-run | |||
| import Clamper "Clamper"; | |||
There was a problem hiding this comment.
Is this file missing from the PR?
There was a problem hiding this comment.
This was a leftover file. I removed it in favor of brittle-stable-functions.drun
crusso
reviewed
Jul 30, 2025
| persistent actor { | ||
| class Clamper(l : Nat, h : Nat) { | ||
| public func clamp(x : Nat) : Nat { | ||
| // When trying to evolve this class to hardcode the upper limit, |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
crusso
reviewed
Jul 30, 2025
| @@ -0,0 +1,15 @@ | |||
| persistent actor { | |||
| class Clamper(low : Nat, high : Nat) { | |||
There was a problem hiding this comment.
I can't tell from the log if the upgrade from Initial to Renamed works or not. I suspect it should from the PR description, but does it fail?
The closures of stable functions are represented in a portable format with the following clearly defined binding of captured variables:
Local variables are captured by name.
Parameters are captured by position (also considering nested functions).
I guess some printfs might help
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.