feat(transactions): implement memo field utils #7399
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
force-pushed
the
yhabib/transactios/utils
branch
from
6ddbf53 to
a143c2a
Compare
2 tasks
mstrasinskis
approved these changes
Oct 8, 2025
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 8, 2025
# Motivation Support the transaction memo for both ICP and ICRC1 addresses in ICP transaction flows. This PR implements the necessary changes to the service layer to encode the memo according to the target address type. Previous PR #7399 # Changes - Update `transferICP` to process the memo field and encode based on the target address type. - Added utils for the conversion. # Tests - Added unit tests for the change. # Todos - [x] Accessibility (a11y) – any impact? - [x] Changelog – is it needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support the transaction memo for both ICP and ICRC1 addresses for ICP transaction flows. This PR adds utils to validate the provided memo:
memofield for ICP account transactions is an unsigned 64-bit integer.icrc1Memofield for ICRC1 account transactions is a byte array with a length of up to 32 bytes.Changes
mapIcpTransactionToUito prepare thememofield for the UI when the value is present. It check first foricrc1Memoas this value is optional, if not present it uses the value from thememofield that is always present.isValidIcpMemo,isValidIcrc1Memo, andvalidateTransactionMemoto validate the different types of memos.Tests
Todos