feat(forms): add transaction memo field support #7405
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yhabib
changed the title
2 tasks
github-merge-queue bot
pushed a commit
that referenced
this pull request
Oct 9, 2025
# Motivation Support the transaction memo for both ICP and ICRC1 addresses in ICP transaction flows. This PR turns on the feature for ICP transaction modal. Previous PR #7405 Testable in [devenv](https://qsgjb-riaaa-aaaaa-aaaga-cai.yhabib-ingress.devenv.dfinity.network/) # Changes - Added a memo to the `TransactionCard` based on the memo store. - Turn on the `withMemo` option in the `IcpTransactionModal` for use by all other child components. # Tests - Added a test for the `IcpTransactionModal` to check the conditionality of the memo and to forward the value to the service layer. - Added a test for the conditionality of the memo in the `TransactionCard`. # Todos - [x] Accessibility (a11y) – any impact? - [x] Changelog – is it needed?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Support the transaction memo for both ICP and ICRC1 addresses in ICP transaction flows. This PR implements the necessary changes in the transaction form components to include the memo field when activated by a prop.
Previous PR #7403
Changes
TransactionMemoto render the memo field.TransactionFormto support memo and validate it based on the destination address.TransactionReviewto display the memo field in the summary.Tests
Todos