Skip to content

Conversation

yhabib
Copy link
Contributor

@yhabib yhabib commented Oct 13, 2025

Motivation

The automatic job #7382 failed as there is a new method on the Storable trait. This method was added here.

Changes

Tests

  • CI should pass

Todos

  • Accessibility (a11y) – any impact?
  • Changelog – is it needed?

dependabot bot and others added 2 commits October 13, 2025 16:34
Bumps [ic-stable-structures](https://github.com/dfinity/stable-structures) from 0.6.9 to 0.7.2.
- [Release notes](https://github.com/dfinity/stable-structures/releases)
- [Changelog](https://github.com/dfinity/stable-structures/blob/main/RELEASE_GUIDE.md)
- [Commits](dfinity/stable-structures@v0.6.9...v0.7.2)

---
updated-dependencies:
- dependency-name: ic-stable-structures
  dependency-version: 0.7.2
  dependency-type: direct:production
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@yhabib yhabib force-pushed the yhabib/bump-stable-structs branch from 43c8ee7 to b0345ad Compare October 13, 2025 14:34
@yhabib yhabib changed the title fix(types): implement missing storable trait method chore(deps): bump ic-stable-structures from 0.6.9 to 0.7.2 Oct 13, 2025
@yhabib yhabib requested a review from Copilot October 13, 2025 15:32
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Updates the ic-stable-structures dependency from version 0.6.9 to 0.7.2 and implements the newly required into_bytes method on the Storable trait.

  • Added the missing into_bytes method implementation for the Account struct
  • Updated dependency version in Cargo.toml
  • Modified PartialEq implementation to use a more explicit comparison approach

Reviewed Changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
rs/backend/Cargo.toml Updates ic-stable-structures dependency to version 0.7.2
rs/backend/src/accounts_store.rs Implements required into_bytes method and updates PartialEq logic

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@yhabib yhabib requested a review from jasonz-dfinity October 13, 2025 15:34
@yhabib yhabib marked this pull request as ready for review October 13, 2025 15:49
@yhabib yhabib requested a review from a team as a code owner October 13, 2025 15:49
@yhabib yhabib enabled auto-merge October 16, 2025 05:24
@yhabib yhabib added this pull request to the merge queue Oct 16, 2025
Merged via the queue into main with commit 889f37a Oct 16, 2025
45 of 47 checks passed
@yhabib yhabib deleted the yhabib/bump-stable-structs branch October 16, 2025 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants