Support ipv6, dns-*, source and more hooks #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@nMustaki which branch do you want me to create a PR against? I tried both of your branches and it gave me |
Contributor
|
devel please, and I'll fix the conflicts if you don't have the time to do it. Thanks again ! |
Contributor
|
Hi, could you open your pr on my devel branch, I'd like to make a release very soon ! I can handle the conflicts if that's blocking you😉 |
Author
|
@nMustaki I'm sorry, I'm puzzled. I thought I already created a PR on your devel branch, but I can't find it there now. |
Contributor
|
No problem!
…On Sun, 27 Nov 2016, 08:57 T. Tran, ***@***.***> wrote:
@nMustaki <https://github.com/nMustaki> I'm sorry, I'm puzzled. I thought
I already created a PR on your devel branch, but I can't find it there now.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#10 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AA-fUVarp6Qrt-UrYh6qKfoKkBwi9eUfks5rCTfZgaJpZM4ISwXE>
.
|
Contributor
|
Hi @t-tran , still waiting for your pull request on my fork, so I can merge it :-) |
Author
|
@nMustaki just did it, feel free to cherrypick anything from the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gatewayis not always an IP, it can also be something like:12.34.56.78 metric 10