-
Notifications
You must be signed in to change notification settings - Fork 2
Update fetch #51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Update fetch #51
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
d48abe7
fix fetching from remote resource
TatsatJha 3480537
use data from remote resource to render citations, bugs exist
TatsatJha f588dd8
more debugging and using remote for collections handling
TatsatJha 193dab2
fix bugs and allow custom groupid in get remote
TatsatJha cfdefbe
update cite to use new form of fetching
TatsatJha 705c031
debug fetching data for large sets
TatsatJha 8acb3a0
add method to fetch all data from large sets, still static
TatsatJha 41d65ce
fix endpoint
TatsatJha 4e7bafa
add hugo-powered method of parsing collection tree
TatsatJha 3d66aac
update collection processing logic, bug now only exists in rendering
TatsatJha 1ca005a
add dynamic fetching, remove debug statements
TatsatJha a5adc0d
fix spell errors
TatsatJha File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's hard for me to follow the filter logic above this, but when I disable the include check I get citations displaying. Without it, none of them display for me (even when I am not passing filters to the shortcode).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey Rebeecca, I'm trying to make the filter logic more readable right now, but it was working correctly for me, what exactly led to none of the citations displaying?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was testing on my personal site, where I started trying to integrate hugo-biblography - I wanted to do something like a customized version of the 'my publications' that zotero lets you set up on your personal profile.
However, in hindsight, that isn't the best place to test since I haven't gotten it fully working. What do you recommend for testing? Should I use the dh-tech site and switch to this branch for testing?