Fix OOB read from unterminated player names in save/network data - #8651
Merged
StephenCWills merged 1 commit intoJul 27, 2026
Merged
Conversation
StephenCWills
approved these changes
Jul 27, 2026
Member
What |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces unbounded string operations with explicitly bounded
std::string_viewconstruction, following the security audit finding inSECURITY_AUDIT.md(section D).Possible with a crafted save file or malicious network packet
PlayerPack::pNameandPlayerNetPack::pNamearechar[32]fields populated viamemcpyfrom raw save archives or network data. If a crafted save file (or malicious peer in multiplayer) fills all 32 bytes with non-null characters, the name has no null terminator within the buffer.pfile.cpp:706usedstrcpy(hero_names[i], pkplr.pName), which scans indefinitely for a null byte, causing an out-of-bounds read on the source and a potential out-of-bounds write past the 32-byte destination.pack.cpp:370andpack.cpp:468(UnPackPlayer,UnPackNetPlayer) passedpacked.pNametoCopyUtf8, which accepts astd::string_view. The implicitchar[32]→std::string_viewconversion callsstrlen()internally, triggering the same unbounded scan beforeCopyUtf8ever executes.