Skip to content

Fix Alpine's assert-statement conversion special case #8438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Fix Alpine's assert-statement conversion special case #8438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 22 additions & 0 deletions regression/ansi-c/goto_convert_assert/main.c
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
void __assert_fail(char *, char *, unsigned, char *);

int main()
{
(void)((1 < 2) || (__CPROVER_assert(0, ""), 0));

int jumpguard;
jumpguard = (jumpguard | 1);
label_1:;
{
while(1)
{
if(jumpguard == 0)
{
__assert_fail("0", "lc2.c", 8U, "func");
goto label_1;
}
goto label_2;
}
label_2:;
}
}
7 changes: 7 additions & 0 deletions regression/ansi-c/goto_convert_assert/test.desc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
CORE test-c++-front-end
main.c

^EXIT=0$
^SIGNAL=0$
--
^warning: ignoring
5 changes: 4 additions & 1 deletion src/ansi-c/goto-conversion/goto_convert.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1812,8 +1812,11 @@ void goto_convertt::generate_ifthenelse(
if(
is_empty(false_case) && true_case.instructions.size() == 2 &&
true_case.instructions.front().is_assert() &&
true_case.instructions.front().condition().is_false() &&
simplify_expr(true_case.instructions.front().condition(), ns).is_false() &&
true_case.instructions.front().labels.empty() &&
true_case.instructions.back().is_other() &&
true_case.instructions.back().get_other().get_statement() ==
ID_expression &&
true_case.instructions.back().labels.empty())
{
true_case.instructions.front().condition_nonconst() = boolean_negate(guard);
Expand Down
Loading