Skip to content

Conversation

kroening
Copy link
Member

@kroening kroening commented Nov 4, 2024

This replaces the use of a typecast expression by zero_extend_exprt when parsing an SMT-LIB2 zero_extend expression.

  • Each commit message has a non-empty body, explaining why the change was made.
  • n/a Methods or procedures I have added are documented, following the guidelines provided in CODING_STANDARD.md.
  • n/a The feature or user visible behaviour I have added or modified has been documented in the User Guide in doc/cprover-manual/
  • Regression or unit tests are included, or existing tests cover the modified code (in this case I have detailed which ones those are in the commit message).
  • My commit message includes data points confirming performance improvements (if claimed).
  • My PR is restricted to a single feature or bugfix.
  • n/a White-space or formatting changes outside the feature-related changed lines are in commits of their own.

Copy link

codecov bot commented Nov 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.93%. Comparing base (fa299c5) to head (7687a69).
Report is 4 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #8493      +/-   ##
===========================================
+ Coverage    78.63%   78.93%   +0.30%     
===========================================
  Files         1728     1728              
  Lines       199408   198654     -754     
  Branches     18316    18352      +36     
===========================================
+ Hits        156797   156810      +13     
+ Misses       42611    41844     -767     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -693,9 +693,9 @@ exprt smt2_parsert::function_application()
else if(id=="zero_extend")
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While at it: please change to id == ID_zero_extend

This replaces the use of a typecast expression by zero_extend_exprt when
parsing an SMT-LIB2 zero_extend expression.
@kroening kroening merged commit ab22e9f into develop Dec 17, 2024
37 of 41 checks passed
@kroening kroening deleted the zero-extend-smt2 branch December 17, 2024 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants