SMV: introduce smv_identifier_exprt
#1362
Merged
+53
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
smv_identifier
branch
from
6bd7bf3 to
627bb47
Compare
tautschnig
approved these changes
Oct 29, 2025
src/smvlang/parser.y
Outdated
| if(expr.id() == ID_symbol) | ||
| return to_symbol_expr(expr).get_identifier(); | ||
| if(expr.id() == ID_smv_identifier) | ||
| return expr.get(ID_identifier); |
Collaborator
There was a problem hiding this comment.
Should probably be to_smv_identifier_expr(expr).identifier()
This introduces a class for the identifiers used in the SMV parse tree. The type checker subsequently turns them into symbols, when this is appropriate.
kroening
force-pushed
the
smv_identifier
branch
from
627bb47 to
fc420ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a class for the identifiers used in the SMV parse tree.
The type checker subsequently turns them into symbols, when this is appropriate.