fix(app): preserve v2 retry and stop reliability - #4590
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
Warden security clearance: clear. No blocking findings (security or desktop↔den sync) in this diff (cf14cd8c7bf86a3a04c7d7fbc35ec9d9ecb6b61a). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run
Test evidence — a-parent-task-surfaces-and-resolves-its-child-session-permission-request — ✅ passedSHA cf14cd8 · engine v2 ✅ 0/1 screenshots passed · 0 expectations passed · 0 failed · 0 pending
[world] desktop(daytona) · workspace(/tmp/openwork-workspace-spec-1788739994788) · session("New task") · [seed:raw] evalIn() ⚪ UNVALIDATED — 1. a-parent-task-surfaces-and-resolves-its-child-session-permission-request artifact 1
Test run created 2026-09-07T00:11:31.633Z · Source: Test evidence — retry-recovery-and-stopping-a-permission-leave-other-requests-and-fresh-work-int — ✅ passedSHA cf14cd8 · engine v2 ✅ 0/1 screenshots passed · 0 expectations passed · 0 failed · 0 pending
[world] desktop(daytona) · workspace(/tmp/openwork-workspace-spec-1788740151164) · session("New task") · [seed:raw] evalIn() · mock(mcp) · den(daytona) · desktop(as admin) · workspace(/tmp/openwork-permission-stop-recovery-1788740403838) · [seed:raw] evalIn() ×4 · session("Stop permission task") · session("Keep permission task") ⚪ UNVALIDATED — 1. retry-recovery-and-stopping-a-permission-leave-other-requests-and-fresh-work-int artifact 1
Test run created 2026-09-07T00:14:10.491Z · Source: Test evidence — a-parent-answers-its-real-child-question-without-settling-an-unrelated-root-ques — ✅ passedSHA cf14cd8 · engine v2 ✅ 0/2 screenshots passed · 0 expectations passed · 0 failed · 0 pending
[world] desktop(daytona) · workspace(/tmp/openwork-workspace-spec-1788740566872) · session("New task") · [seed:raw] evalIn() · mock(mcp) · den(daytona) · desktop(as admin) · workspace(/tmp/openwork-permission-stop-recovery-1788740842042) · [seed:raw] evalIn() ×4 · session("Stop permission task") · session("Keep permission task") · mock(mcp) · den(daytona) · desktop(as admin) · workspace(/tmp/openwork-delegated-question-handoff-1788741090017) · [seed:raw] evalIn() ×4 · session("Delegated question parent") · session("Unrelated question root") ⚪ UNVALIDATED — 1. a-parent-answers-its-real-child-question-without-settling-an-unrelated-root-ques artifact 1
⚪ UNVALIDATED — 2. a-parent-answers-its-real-child-question-without-settling-an-unrelated-root-ques artifact 2
Test run created 2026-09-07T00:21:08.846Z · Source: |
cf14cd8 to
d52e5dd
Compare
There was a problem hiding this comment.
Warden security clearance: clear. No blocking findings (security or desktop↔den sync) in this diff (d52e5dd87366a6bb1685fdafa5bd0360b840b6d1). Automated clearance satisfies the required-review gate only — a human still reviews and merges. Analysis run
Summary
Current Verification: Incomplete
Head: d52e5dd
Base: 7874bf9 (dev)
Rebased onto current dev and resolved two test conflicts by retaining both the newly merged v1/v2 scoped-permission hydration coverage and this lifecycle coverage. No assertions were removed or weakened. All four rebased commits have verified signatures.
Passed on this head:
pnpm --dir apps/app exec bun test --isolate tests/opencode-v2-adapter.test.ts tests/session-sync-run-status.test.ts tests/session-sync-permissions.test.ts: exit 0; 121 passed, 0 failed, 0 skipped; 657 assertions. Includes v1/v2 permission hydration, native v2 lifecycle, and shared status/permission regression coverage.pnpm --dir apps/app typecheck: exit 0.git diff --check origin/dev...HEAD: exit 0.Not run on this head:
OPENWORK_EVAL_ENGINE=v1 pnpm evals:e2e parent-child-permission-approvalOPENWORK_EVAL_ENGINE=v2 pnpm evals:e2e parent-child-permission-approvalThe CLI placement resolver reports
placement: daytona (daytona CLI authenticated). These cold-boot journeys provision cloud resources; execution is pending approval for that resource usage. No local lane override was used. This is an execution-authorization blocker, not a failed product assertion. Both exact-head journey runs and their published evidence are required before declaring merge readiness.The existing evidence comment at cf14cd8 is historical v2 evidence only and does not validate this rebased head. It also does not establish v1 journey coverage.
Scope And Limits
Automatic task resumption after desktop restart is not implemented here. A separate follow-up must support both engines using durable OpenWork-owned recovery intent, explicit Stop/approval/completion exclusions, engine-specific reconciliation, and bounded staggered starts. Live shutdown/restart and supersession remain outside the current journey proof; focused tests cover their lifecycle handling.
No merge, release, or deployment was performed.