-
Notifications
You must be signed in to change notification settings - Fork 9
Fix DOI, broken citation link, and add 404 check to CI #94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
…to CI Co-authored-by: maehr <[email protected]>
Co-authored-by: maehr <[email protected]>
Co-authored-by: maehr <[email protected]>
Updated .gitignore to include additional environment files and cache directories.
Revised text for clarity and consistency in discussing the factors influencing ATR usage in historical projects, including the impact of handwriting heterogeneity, text volume, analysis methods, and research questions.
|
@copilot the 404 checker should also check external URLs (like DOI) and respective redirects. |
Co-authored-by: maehr <[email protected]>
Updated the 404 checker in commit ee2f5db to check external URLs including DOIs. The changes:
|
|
@copilot index all html files first and check for dead links without recursion |
Co-authored-by: maehr <[email protected]>
Refactored in commit f272edb. The 404 checker now:
|
|
@copilot link checking is too greedy, does not resolve internal links correctly it seems. Also only output a warning instead of failing |
…nings Co-authored-by: maehr <[email protected]>
Fixed in commit d86d5a9. Changes:
|
|
@copilot the ci workflow does not stop, fix that |
Co-authored-by: maehr <[email protected]>
Fixed in commit 8e53ab3. Added timeouts to prevent the workflow from hanging:
|
|
@copilot broken link checker produces a lot of false positives. Try different strategies (agents etc.) to mitigate, especially with doi.org, before implementing |
Co-authored-by: maehr <[email protected]>
Replaced wget with the
|
|
The job failed because the lycheeverse/lychee-action@v2 step tried to download lychee-arm64-unknown-linux-gnu.tar.gz but exited with code 56, indicating a download failure. This almost always means the specified binary for the runner platform (here, ARM64 for macOS) does not exist or is unsupported. To fix this:
build-deploy:
runs-on: ubuntu-latest
You can see the relevant section of your workflow here: .github/workflows/quarto-publish.yml (ref: b2e0150). Update the runs-on parameter as shown above to resolve the issue.@copilot fix this |
Co-authored-by: maehr <[email protected]>
Fixed in commit c4bdf07. Instead of changing the runner, I replaced lychee-action with a direct Homebrew installation of lychee, which supports macOS ARM. This keeps the macOS runner for typesetting requirements while still providing reliable link checking. |
Pull request
Proposed changes
Addresses #80, #92, and #93.
DOI Fix (#93): Updated incorrect DOI
10.5281/zenodo.14851523→10.5281/zenodo.14171285insubmissions/445/index.qmd(front matter, href, and Zenodo link).Broken Citation (#92): Fixed malformed citation syntax:
404 Check in CI (#80): Added link validation step to
quarto-publish.ymlusing lychee (installed via Homebrew for macOS ARM compatibility):site_libsfolder to speed up checksTypes of changes
Checklist
Co-authored-by: Name <[email protected]>.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.