.net core 3.1 upgrade #33
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…l helper + remove mvcoption references which are now removed in 3.0
XeNz
commented
Dec 18, 2019
|
|
||
| if (!apiOptions.DisableVersioning) | ||
| { | ||
| builder.AddMvcOptions(options => |
XeNz
commented
Dec 18, 2019
| namespace Digipolis.Web.Swagger | ||
| { | ||
| // This filter is necessary to correct the $Ref in the swagger for response types that are generic types. | ||
| public class ValidRefUri : IOperationFilter |
There was a problem hiding this comment.
Not sure if this is still needed with new swashbuckle version
XeNz
commented
Dec 18, 2019
| [HttpGet()] | ||
| [ProducesResponseType(typeof(PagedResult<ValueDto>), 200)] | ||
| [AllowAnonymous] | ||
| [Versions(Versions.V1, Versions.V2)] |
There was a problem hiding this comment.
versioning is currently probably broken
XeNz
commented
Dec 18, 2019
| { | ||
| // Add framework services. | ||
| services.AddMvc() | ||
| .AddNewtonsoftJson(options => options.SerializerSettings.Initialize()) // set default Digipolis json serializer settings |
There was a problem hiding this comment.
Thisi s a workaround for not being able to use MvcOptions anymore.
Making the initialize public, also lets the consumer hook on the JsonSerializerSettings with an action.
XeNz
commented
Dec 18, 2019
| settings.NullValueHandling = NullValueHandling.Ignore; | ||
| settings.Converters.Add(new TimeSpanConverter()); | ||
| settings.Converters.Add(new GuidConverter()); | ||
| settings.Converters.Add(new StringEnumConverter()); |
There was a problem hiding this comment.
Swashbuckle now adheres at the general JsonSerializerSettings.
DescribeEnumsAsString for SwaggerOptions is deprecated now.
XeNz
commented
Dec 18, 2019
| { | ||
| if (bindingContext.ModelMetadata.IsEnumerableType) | ||
| { | ||
| if (bindingContext == null) |
XeNz
commented
Dec 18, 2019
| { | ||
| protected override void Configuration(SwaggerGenOptions options) | ||
| { | ||
| options.DescribeAllEnumsAsStrings(); |
XeNz
commented
Dec 18, 2019
|
|
||
| namespace Digipolis.Web.UnitTests.Startup | ||
| { | ||
| public class MvcBuilderExtensionsTests |
There was a problem hiding this comment.
Probably needs to be deleted unless we can fix the MvcOptions problem
XeNz
changed the title
|
What's the status of this PR? |
|
Status? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…l helper + remove mvcoption references which are now removed in 3.0