Skip to content

Add weekly snapshot verification step to release/README.md #21859

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Add weekly snapshot verification step to release/README.md #21859

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cb26bdc
Add weekly snapshot verification step to release/README.md
remyhaemmerle-da Sep 4, 2025
2a1056d
address Fabio review
remyhaemmerle-da Sep 4, 2025
ff3c509
cosmetic
remyhaemmerle-da Sep 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions sdk/release/RELEASE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,6 +74,15 @@ using the steps in the previous section.

## Testing

For the weekly snapshot of the main branch, before merging the
assembly PR, verify that the SDK snapshot used in the release is not
older than one week. If it is outdated, open a #team-daml thread
tagging @martino, @Raf, @soren, and @Tom Tantillo, stating that the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you mean to make these GH handles? I see that some of them don't match. If not, I'd rather remove the '@' and use just full names of the people

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe Slack handles? They can change and reference another system, so perhaps still I'd use just the full names.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Those are slack handles. I used slack handle instead full name here, so the guy on rota can just copy past them in slack.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reworded

release will be skipped this week unless instructed otherwise. Then,
close the two automatically generated PRs (one in the assembly repo
and the rotate release duty PR in the SDK repo) and halt the testing
process.

This testing procedure starts once the release is listed on the [releases
page]. That is, _after_ the [assembly] step has finished.

Expand Down