Add Circle Attestation Daml Testing #21954
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpulley-da
commented
Oct 10, 2025
carlpulley-da
commented
Oct 10, 2025
carlpulley-da
commented
Oct 10, 2025
sdk/compiler/damlc/tests/daml-test-files/AttestationTestData.daml
Outdated
Show resolved
Hide resolved
remyhaemmerle-da
approved these changes
Oct 15, 2025
carlpulley-da
added a commit
that referenced
this pull request
Oct 16, 2025
carlpulley-da
added a commit
that referenced
this pull request
Oct 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #21951
ensure we can relate expected (from attestation test data) and actual (as calculated by Java) test message signatures-test.signatureandderEncodedSignatureuse different random sources to generate an offset multiplier of a common generator value, hence they can not be directly compared and we're forced to check that both signatures are valid.Note: secp256k1 signing can only be accessed via daml-script - hence its use of a random source (to generate a signature) should ow be benign.