update canton to 20251009.17126.v6d38818f #22075
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tell-slack: canton
This PR promotes upgrade error messages from dev errors to full-fledged errors understood and reported by Canton. Upgrade errors are classified into 3 categories: - ValidationFailed: already exists in 3.3, returned when the metadata of a contract changed - TranslationFailed: raised for any error that can happen during the type-checking/translation of a contract: failed to look up some identifier, type mismatch, value too deeply nested, non-suffixed contract id encountered, unexpected label in record value, unordered GenMap. - AuthenticationFailed: the computed hash doesn't match the contract ID I also introduce a new toplevel error: ContractHashingError. I put it at toplevel for consistency with DisclosedContractKeyHashingError and also because I suspect it might occur outside of upgrades in the future. For this error to be raised, something needs to go really wrong: like a user providing a disclosure whose key contains a contract ID. I could probably have been a crash but I have a hard time convincing myself that it won't happen in some scenarios so I made it an error. (cherry picked from commit 310a3e5)
We have adapted the engine-side check to package imports (a.k.a. "Carl's check") with logic similar to #21740 --------- Co-authored-by: Remy <[email protected]> (cherry picked from commit 71bf1cb)
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
atriantafyllos-da
approved these changes
Oct 10, 2025
|
subsumed by #22083 |
auto-merge was automatically disabled
October 13, 2025 12:17
Pull request was closed
atriantafyllos-da
deleted the
main-canton-update-20251009.17126.v6d38818f
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tell-slack: canton