Devcontainer: Fix missing yarn gpg key

[jarlhengstmengel]

Short description

This fixes missing public gpg key for yarn when building the docker image in the devcontainer. I used the solution as mentioned in the comment section of this bug report. This came up while I tried to rebuild my devcontainer in VS code.

Proposed changes

• Curl for public gpg key for yarn and store it so that apt finds it

Side effects

• Should be none. I'm not entirely shure if this is something that is going to be solved externally or if this is a good long term fix for us here

Faithfulness to issue description and design

There are no intended deviations from the issue and design.

How to test

Build the devcontainer in VS Code

Resolved issues

Fixes: # n.a.

---

Pull Request Review Guidelines

[dkehne]

Since yarn is never installed via apt in this Dockerfile (Node comes through n), would it be simpler to just remove the stale source list instead?

RUN rm -f /etc/apt/sources.list.d/yarn.list

That way we don't depend on an external URL and avoid the same issue if the key expires again.

[dkehne]

Minor nit: the new RUN could be folded into the next one to avoid an extra Docker layer:

RUN rm -f /etc/apt/sources.list.d/yarn.list && \
    apt-get update && \
    ...

[hannaseithe]

Please correct me if I am wrong: I am not entirely sure this PR is actually necessary. I am assuming the yarn.list file only exists locally on your container? Probably you added the file when installing yarn manually at some point, since the build itself doesn't create it. And if that is the case, I would expect you to do a manual rm -f /etc/apt/sources.list.d/yarn.list.

Honestly I doubt yarn is enabled and therefore used at all. @dkehne said its installed through n, which is true as it installs corepack with node (from Node.js 14.19 / 16.9) . But since we do not seem to enable corepack anywhere, yarn cant also be used.

[hannaseithe]

See my comment above

[MizukiTemma]

From Weekly on 08.04: we'll review and merge this PR as it is necessary for people using dev container.

[MizukiTemma]

I didn't observe any harm as user without dev container -> Approved 😸