add sortable table headers in POI list view#4194
Open
Conversation
MizukiTemma
requested changes
Mar 17, 2026
Member
MizukiTemma
left a comment
There was a problem hiding this comment.
Contributor
Author
|
@MizukiTemma thanks for your review! I thought I had that already covered, but it turns out the way Django ORM works in this respect is more complex than I thought. I learned something new from that 😄 |
Merged
MizukiTemma
approved these changes
Mar 19, 2026
Member
MizukiTemma
left a comment
There was a problem hiding this comment.
Thank you for updates 👍 Works as expected, the codes look also nice 😸
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Short description
Add sort function to POI list view
Proposed changes
render_table_headerhelper function could not be used. instead, thesort_linktag is used directly in the sortable table headersSide effects
table_fieldsproperty, it needs to be ensured that every change in the table headers in the template is also reflected in thetable_fieldsFaithfulness to issue description and design
There are no intended deviations from the issue and design.
How to test
Resolved issues
Fixes: #1936
Pull Request Review Guidelines