add get_safe_page helper method for ModelListView#4229
Open
add get_safe_page helper method for ModelListView#4229
Conversation
jonbulz
force-pushed
the
fix/catch-empty-page-exception
branch
from
50accef to
84b12ca
Compare
3 tasks
MizukiTemma
approved these changes
Apr 7, 2026
Member
MizukiTemma
left a comment
MizukiTemma
left a comment
There was a problem hiding this comment.
Looks good 😸 Thank you for speedy fix!
We can add a release note, this fix is visible for users 📝
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description
Changing the page size in a list view can result in a 404 exception if the page does not exist with the new entries per page setting.
PaginationMixin(introduced in #3963 ) handles this gracefully, but our existingModelListViewsdon't usePaginationMixin. This PR introduces a shared helper method to handleEmptyPageexceptions in all list views.Proposed changes
get_safe_pagehelper method and use it inPaginationMixinandModelListViewSide effects
Faithfulness to issue description and design
There are no intended deviations from the issue and design.
How to test
Ensure that no 404 occurs on any list view when changing the page size
Resolved issues
Fixes: #3249
Pull Request Review Guidelines