fix: Allow spaces in shared vault name #19
Conversation
|
Hm what am I missing for the 2 failing pipeline steps to succeed? 🤔 @HartmannVolker |
|
Alright, fixed the documentation error in the other module with #20 |
HartmannVolker
left a comment
HartmannVolker
left a comment
There was a problem hiding this comment.
The other test that's failing is checking if the auto generated terraform docs are up-to date. I don't know why they are not though, because you didn't change anything in the object storage module 🤔
Is your branch up to date with the latest main?
| variables { | ||
| state_bucket_name = "test-bucket-default" | ||
| write_backend_config_file = false | ||
| create_onepassword_item = true |
There was a problem hiding this comment.
This should be false. Otherwise terraform will create the null_resources that is trying to run the 1password cli. This is what's failing in the pipeline right now.
You can still assert the output though. This is why I created them
There was a problem hiding this comment.
aha! nice
I was trying locally to also use the 1password provider for this and then use a mock in the test.
marcel-wollschlaeger
force-pushed
the
allow-spaces-in-vault-name
branch
from
53dd0d0 to
c9c8bec
Compare
When creating the 1Password Item in a shared vault, e.g.
Team NeuRIS, we need to escape the string as the command would otherwise fail on the command line.