Skip to content

Fixed errors with swift 5#90

Open
schenkty wants to merge 2 commits intodillidon:newfrom
schenkty:new
Open

Fixed errors with swift 5#90
schenkty wants to merge 2 commits intodillidon:newfrom
schenkty:new

Conversation

@schenkty
Copy link
Copy Markdown

@schenkty schenkty commented Jun 5, 2019

Converted code from Swift 4 to 5 and fixed a few errors along with a ton of warnings

Copy link
Copy Markdown

@Horse888 Horse888 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ready to merge.

Copy link
Copy Markdown

@tinyprocessing tinyprocessing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All fine

Copy link
Copy Markdown

@Dhaval3110 Dhaval3110 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All work done perfactly

@ryanholden8
Copy link
Copy Markdown

@dillidon - Love the work on this project! Could we get this merged so our team can leverage this great library?

@invinciible
Copy link
Copy Markdown

Ready to merge.

Please approve

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants