Skip to content

Tweak The Mobile PR Builder Skill (Part Two)#31

Merged
conroy-ricketts merged 6 commits intomainfrom
tweak-mobile-pr-builder-skill-part-two
May 7, 2026
Merged

Tweak The Mobile PR Builder Skill (Part Two)#31
conroy-ricketts merged 6 commits intomainfrom
tweak-mobile-pr-builder-skill-part-two

Conversation

@conroy-ricketts
Copy link
Copy Markdown
Contributor

@conroy-ricketts conroy-ricketts commented Apr 30, 2026

Based on feedback from the mobile dev team, I tweaked/improved the mobile PR builder skill.

Summary of the changes:

  • Draft mode, no review-and-approve loop. The "show draft, wait for approval" step is gone. The skill now opens the PR with --draft and the user iterates on GitHub.
  • No reviewers requested. --reviewer dimagi/connect-mobile-devs removed; reviewer selection is the user's job once they un-draft.
  • QA notes go to RELEASES.md. New step 4 appends bullets to the QA Notes subsection of the most recent CommCare X.YZ release and commits the change on the branch. The PR description's QA Plan section becomes a pointer to RELEASES.md.
  • QA notes constrained to phone-only access. Explicit list of forbidden tooling (Android Studio, Logcat, adb, unit/instrumentation tests, internal storage inspection, source code) plus guidance to write user-level actions and observable outcomes only.
  • Neutral safety story. Replaced the "argue why it's safe" framing with two lists: What gives confidence (only items actually true) and risks to review (honest, unmitigated risks left visible for the reviewer to weigh).
  • Explicit ask for the author's personal testing. New step 3 requires the skill to ask the user what they did to verify the change before generating the description, and forbids fabricating testing they did not describe.
  • Common mistakes list updated to match.
  • Moved the skill to the dev_utils plugin since both CommCare and Connect divisions can use it.
  • Updated the plugins README.

@conroy-ricketts conroy-ricketts self-assigned this Apr 30, 2026
@conroy-ricketts conroy-ricketts marked this pull request as ready for review April 30, 2026 19:22
@conroy-ricketts
Copy link
Copy Markdown
Contributor Author

conroy-ricketts commented Apr 30, 2026

I plan on testing this new version of the skill on a real feature I'm working on soon - planning not to merge this PR until I test it.

@conroy-ricketts
Copy link
Copy Markdown
Contributor Author

@shubham1g5 @Jignesh-dimagi @OrangeAndGreen

Finally tested this with a new PR created here: dimagi/commcare-android#3686

Based on that, I made another slight tweak to this skill in the latest commit: d5d06a3

@conroy-ricketts conroy-ricketts merged commit 4f72591 into main May 7, 2026
@conroy-ricketts conroy-ricketts deleted the tweak-mobile-pr-builder-skill-part-two branch May 7, 2026 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants