Skip to content

Remove support for dynamic search#1772

Merged
MartinRiese merged 2 commits into
masterfrom
riese/rm_dynamic_search
May 7, 2026
Merged

Remove support for dynamic search#1772
MartinRiese merged 2 commits into
masterfrom
riese/rm_dynamic_search

Conversation

@MartinRiese
Copy link
Copy Markdown
Contributor

@MartinRiese MartinRiese commented May 6, 2026

Product Description

Commcare HQ does not set the dynamic search flag anymore. It has been removed in this PR: dimagi/commcare-hq#37634. Formplayer should behave the same way as
if the flag is set to false.

commcare-core PR: dimagi/commcare-core#1537

Technical Summary

https://dimagi.atlassian.net/browse/USH-6541

Safety Assurance

Safety story

Automated test coverage

QA Plan

Special deploy instructions

  • This PR can be deployed after merge with no further considerations. HQ code already has been deployed.

Rollback instructions

  • This PR can be reverted after deploy with no further considerations.

Review

  • The set of people pinged as reviewers is appropriate for the level of risk of the change.

@MartinRiese MartinRiese marked this pull request as ready for review May 6, 2026 17:52
@codecov
Copy link
Copy Markdown

codecov Bot commented May 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 70.08%. Comparing base (14f69ec) to head (153da83).

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #1772      +/-   ##
============================================
- Coverage     70.10%   70.08%   -0.02%     
+ Complexity     2030     2028       -2     
============================================
  Files           257      257              
  Lines          8011     8007       -4     
  Branches        764      764              
============================================
- Hits           5616     5612       -4     
  Misses         2112     2112              
  Partials        283      283              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MartinRiese MartinRiese requested a review from shubham1g5 May 6, 2026 18:19
@MartinRiese MartinRiese force-pushed the riese/rm_dynamic_search branch from 0611308 to af4bce2 Compare May 6, 2026 20:12
@MartinRiese MartinRiese requested a review from esoergel May 7, 2026 12:58
@MartinRiese MartinRiese enabled auto-merge May 7, 2026 16:18
@MartinRiese MartinRiese merged commit 7f3edf4 into master May 7, 2026
7 checks passed
@MartinRiese MartinRiese deleted the riese/rm_dynamic_search branch May 7, 2026 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants